Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak warning diagnostic toggle #18637

Merged

Conversation

danilo-leal
Copy link
Contributor

This PR adds color to the warning diagnostic toggle, so that, if it's turned on, the warning icon is yellow. And, in the opposite case, it's muted.

Turned on Turned off
Screenshot 2024-10-02 at 6 08 30 PM Screenshot 2024-10-02 at 6 08 36 PM

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Oct 2, 2024
@danilo-leal danilo-leal merged commit a5f50e5 into zed-industries:main Oct 2, 2024
9 checks passed
@danilo-leal danilo-leal deleted the tweak-warning-diagnositc-toggle branch October 2, 2024 16:57
schpet added a commit to schpet/zed that referenced this pull request Oct 3, 2024
* upstream/main: (76 commits)
  Remove a debug dev config line (zed-industries#18689)
  Update Rust crate thiserror to v1.0.64 (zed-industries#18677)
  Add command palette action name to outline panel docs (zed-industries#18678)
  Add basic outline panel docs (zed-industries#18674)
  ssh: Add session state indicator to title bar (zed-industries#18645)
  Update Rust crate clap to v4.5.19 (zed-industries#18660)
  Sort dependencies in `Cargo.toml` files (zed-industries#18657)
  collab: Revert changes to Clickhouse event rows (zed-industries#18654)
  Replace isahc with async ureq (zed-industries#18414)
  Update cloudflare/wrangler-action digest to 168bc28 (zed-industries#18651)
  Prepare to sync other kinds of settings (zed-industries#18616)
  editor: Ensure proposed changes editor is syntax-highlighted when opened (zed-industries#18648)
  language: Update buffer doc comments (zed-industries#18646)
  Revert "Fix blurry cursor on Wayland at a scale other than 100%" (zed-industries#18642)
  Tweak warning diagnostic toggle (zed-industries#18637)
  Adjust spacing and sizing of buffer search bar icon buttons (zed-industries#18638)
  docs: Add missing UI font settings to "Configuring Zed" (zed-industries#18267)
  Use `const` over `static` for string literals (zed-industries#18635)
  docs: Add FIPS mode error to Linux troubleshooting (zed-industries#18407)
  v0.157.x dev
  ...
noaccOS pushed a commit to noaccOS/zed that referenced this pull request Oct 19, 2024
This PR adds color to the warning diagnostic toggle, so that, if it's
turned on, the warning icon is yellow. And, in the opposite case, it's
muted.

| Turned on | Turned off |
|--------|--------|
| <img width="1136" alt="Screenshot 2024-10-02 at 6 08 30 PM"
src="https://github.com/user-attachments/assets/be64738b-4c14-41d4-b1d4-ad788cf9e72b">
| <img width="1136" alt="Screenshot 2024-10-02 at 6 08 36 PM"
src="https://github.com/user-attachments/assets/d144ff50-4bf6-4c23-925a-05bcbbcd8b9d">
|

---

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant