Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resize windows using the keyboard #8628

Closed
1 task done
Massolari opened this issue Feb 29, 2024 · 2 comments · Fixed by #21038
Closed
1 task done

Resize windows using the keyboard #8628

Massolari opened this issue Feb 29, 2024 · 2 comments · Fixed by #21038
Labels
enhancement [core label] keymap / key binding Feedback for keyboard shortcuts, key mapping, etc vim workspace Feedback for workspace management, layout, interactions, etc

Comments

@Massolari
Copy link

Massolari commented Feb 29, 2024 •
edited
Loading

Check for existing issues

  • Completed

Describe the feature

In Vim we have the :resize command that we can use to resize windows, it'd be nice if we had something similar so we could map to a key and resize windows using the keyboard

If applicable, add mockups / screenshots to help present your vision of the feature

No response
@Massolari Massolari added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels Feb 29, 2024
@JosephTLyons JosephTLyons added workspace Feedback for workspace management, layout, interactions, etc keymap / key binding Feedback for keyboard shortcuts, key mapping, etc vim and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Feb 29, 2024
@JosephTLyons
Copy link
Collaborator

I added the vim label, but this might be nice outside of vim mode as well.

@github-actions github-actions bot mentioned this issue Mar 1, 2024
Open
@mbylstra
Copy link

Yeah, whether it's vim or a native way to be able to resize a pane using the keyboard, not having it is one of my biggest pain points coming from VSCode.

@github-actions github-actions bot mentioned this issue Oct 10, 2024
Open
@AidanV AidanV mentioned this issue Nov 22, 2024
Merged
ConradIrwin added a commit that referenced this issue Nov 27, 2024
@AidanV @ConradIrwin
Add support for resizing panes using vim motions (#21038)
f702575 
Closes #8628

Release Notes:

- Added support for resizing the current pane using vim keybinds with
the intention to follow the functionality of vim
  - "ctrl-w +" to make a pane taller 
  - "ctrl-w -" to make the pane shorter
  - "ctrl-w >" to make a pane wider
  - "ctrl-w <" to make the pane narrower
- Changed vim pre_count and post_count to globals to allow for other
crates to use the vim count. In this case, it allows for resizing by
more than one unit. For example, "10 ctrl-w -" will decrease the height
of the pane 10 times more than "ctrl-w -"
- This pr does **not** add keybinds for making all panes in an axis
equal size and does **not** add support for resizing docks. This is
mentioned because these could be implied by the original issue

---------

Co-authored-by: Conrad Irwin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement [core label] keymap / key binding Feedback for keyboard shortcuts, key mapping, etc vim workspace Feedback for workspace management, layout, interactions, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for resizing panes using vim motions AidanV/zed
3 participants
@mbylstra @Massolari @JosephTLyons