New shortcut to select all matching text

[exalted]

VSCode calls this "select all occurrences of find match", and the gist is that I'd like to be able to select a piece of text (usually a word, a function name, a variable name, etc.) hit the keyboard combo (e.g., Cmd-Ctrl-g) and have all occurrences being selected.

Right now the workaround I am using is to select the text and keep Cmd-d pressed until it selects all matching text.

[iamnbutler]

Want

[JosephTLyons]

This would be a really nice way to do replaces in a single buffer - just grab all text and change it all at once.

[SomeoneToIgnore]

Intellij provides somewhat enhanced functionality that allows to not only do "select all matches" thing, but also to add/remove such selections one by one, while searching.

[porsager]

This is the only thing keeping me with Sublime. Is there any way to know if this is considered and if there's a plan to add it?

[ryanwinchester]

Was just about to main Zed with some fixes I've been waiting for in v0.90.

However, I'm 10 minutes in and I don't know if I can live without this. I use it quite a bit.

[probablykasper]

I think VSCode's Cmd-Shift-L shortcut would be nice, instead of involving Ctrl

[ryanwinchester]

@SomeoneToIgnore Will this work in the Editor context, not just the BufferSearchBar mentioned in #6208, since I see they were referenced to each other and closed in the same version? 🙏

i.e. would work alongside this section's editor::selectNext as something like editor::selectAll?

  // Bindings from VS Code
  {
    "context": "Editor",
    "bindings": {
      "cmd-[": "editor::Outdent",
      "cmd-]": "editor::Indent",
      "cmd-alt-up": "editor::AddSelectionAbove",
      "cmd-ctrl-p": "editor::AddSelectionAbove",
      "cmd-alt-down": "editor::AddSelectionBelow",
      "cmd-ctrl-n": "editor::AddSelectionBelow",
      "cmd-d": [
        "editor::SelectNext",
        {
          "replace_newest": false
        }
      ],
      "ctrl-cmd-d": [
        "editor::SelectPrevious",
        {
          "replace_newest": false
        }
      ],
      "cmd-k cmd-d": [
        "editor::SelectNext",
        {
          "replace_newest": true
        }
      ],
      "cmd-k ctrl-cmd-d": [
        "editor::SelectPrevious",
        {
          "replace_newest": true
        }
      ],
     // ...
}

[porsager]

Wooo.. awesome.. Can't wait to try it out.. Is there a date for 0.96?

[SomeoneToIgnore]

The feature pretty much mimics VSCode behavior at this point: as long as the buffer search input is open, whether the caret is inside the editor or inside the search input, the action will focus to the editor and select + place the caret to all matches.

Screen is not moved, the selection number stays the same with selectNext and reverse continuing the search, if invoked after selectAll (all but one carets will be removed again in this case).

So far, the feature does not touch the project search (with multiple editors), only a singleton buffers are affected.

The configuration by default was placed in the BufferSearchBar context, alongside the other search-related items:

{
    "context": "BufferSearchBar",
    "bindings": {
      "escape": "buffer_search::Dismiss",
      "tab": "buffer_search::FocusEditor",
      "enter": "search::SelectNextMatch",
      "shift-enter": "search::SelectPrevMatch",
      "alt-enter": "search::SelectAllMatches"
    }
  },

and duplicated for Pane context.

Also, there's now a button in the search bar itself:

---

The release is supposed to happen in ~2 weeks for Stable and one week for Preview, somewhere around Wednesday.

[ryanwinchester]

as long as the buffer search input is open

@SomeoneToIgnore that is not cmd-shift-L (or ctrl-cmd-g in Sublime)

It should be like cmd-d except instead of Next it's All. There is no search buffer when doing this. It's happening to selected text in the editor.

I think #6208 was incorrectly associated with this one

[SomeoneToIgnore]

That is all very confusing, looks I was wrong indeed.
Let's reopen this issue, and keep my original message as a workaround: you can now select a text, press Cmd+F and Alt + Enter to achieve similar effect with one extra shortcut.

[ryanwinchester]

@SomeoneToIgnore cmd-shift-L in VS Code example

Screen.Recording.2023-07-14.at.5.06.45.PM.mov

[ryanwinchester]

@JosephTLyons this was re-opened but it's not in #5393 anymore (just sayin 😅)

[JosephTLyons]

@JosephTLyons this was re-opened but it's not in #5393 anymore (just sayin 😅)

Was it in #5393 recently? It looks like the issue at the end of the list has 40 upvotes and this one has 25, so I dont think it has had enough votes to be there, at least not for a long time.

[ryanwinchester]

I could be wrong, I just saw this on this issue's timeline and assumed it used to be in there.

Maybe it had been grouped with other issue(s)... Sorry about the ping

[JosephTLyons]

Wooo.. awesome.. Can't wait to try it out.. Is there a date for 0.96?

We ship a new minor version every Wednesday (unless its a crazy holiday time). Right now, stable is at v0.94. So v0.96 should go out the Wednesday after next (July 26th).

Edit: Missed Kirill's comment explaining it, my bad. 😅

[JosephTLyons]

I could be wrong, I just saw this on this issue's timeline and assumed it used to be in there.

Maybe it had been grouped with other issue(s)... Sorry about the ping

Yeah you're right, I think it was on there a long time ago, when we first started getting upvotes and all issues were kind of in the top. It got booted off sometime after that as other issues were upvoted past it.

[ryanwinchester]

Every Wednesday I open up Zed and check the update and every Wednesday I sad.

[JosephTLyons]

Every Wednesday I open up Zed and check the update and every Wednesday I sad.

No reason to be sad today @ryanwinchester, it will be going out today in v0.105.0-pre :)

[JosephTLyons]

Ok, so this is officially released, but we made a mistake and put in the wrong binding. We used cmd-shift-d, which by default is duplicate line, so we're going to put out a patch to make it cmd-shift-l. Hang tight.

[JosephTLyons]

We also have a crash when the selection is empty - this will be fixed in the same patch.