Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Go-To-Def with Yarn PnP #10107

Closed
1 task done
mmtftr opened this issue Apr 3, 2024 · 0 comments · Fixed by #13644
Closed
1 task done

Support for Go-To-Def with Yarn PnP #10107

mmtftr opened this issue Apr 3, 2024 · 0 comments · Fixed by #13644
Assignees
@osiewicz
Labels
enhancement [core label] javascript JavaScript programming language support language server An umbrella label for all language servers language An umbrella label for all programming languages syntax behaviors tooling An umbrella label for language tools, linters, formatters, etc typescript TypeScript programming language support

Comments

@mmtftr
Copy link
Contributor

mmtftr commented Apr 3, 2024

Check for existing issues

  • Completed

Describe the feature

With Yarn PnP, packages are resolved from a separate location from within zip files. There is @yarnpkg/sdks for language server support. Using the sdks, it's possible to have TSServer resolve packages correctly, however go-to-definition for packages will not work as the file itself is within a zip file. The URL given by the LSP will be a zip url and zed will open an empty buffer when resolving it.

VSCode supports this workflow with the ZipFS extension. The extension simulates a filesystem for the zip file.

If applicable, add mockups / screenshots to help present your vision of the feature

Screenshot 2024-04-03 at 10 58 22

The file inside the zip archive should be opened instead. It can be read-only if necessary.
@mmtftr mmtftr added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels Apr 3, 2024
@Moshyfawn Moshyfawn added typescript TypeScript programming language support javascript JavaScript programming language support language An umbrella label for all programming languages syntax behaviors language server An umbrella label for all language servers tooling An umbrella label for language tools, linters, formatters, etc and removed triage Maintainer needs to classify the issue labels Apr 3, 2024
@JosephTLyons JosephTLyons removed the admin read Pending admin review label Apr 4, 2024
@github-actions github-actions bot mentioned this issue Apr 7, 2024
Open
@osiewicz osiewicz self-assigned this Jun 26, 2024
@osiewicz osiewicz mentioned this issue Jun 28, 2024
Merged
1 task
@SomeoneToIgnore SomeoneToIgnore mentioned this issue Jul 10, 2024
Closed
1 task
osiewicz added a commit that referenced this issue Jul 11, 2024
@osiewicz @m4saurabh
Add support for projects managed with Yarn (#13644)
2727f55 
TODO:
- [ ] File a PR with Yarn to add Zed to the list of supported IDEs.

Fixes: #10107
Fixes: #13706
Release Notes:

- Improved experience in projects using Yarn. Run `yarn dlx
@yarnpkg/sdks base` in the root of your project in order to elevate your
experience.

---------

Co-authored-by: Saurabh <[email protected]>
@db82407 db82407 mentioned this issue Jul 26, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@osiewicz osiewicz

Labels
enhancement [core label] javascript JavaScript programming language support language server An umbrella label for all language servers language An umbrella label for all programming languages syntax behaviors tooling An umbrella label for language tools, linters, formatters, etc typescript TypeScript programming language support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for projects managed with Yarn zed-industries/zed
4 participants
@mmtftr @Moshyfawn @JosephTLyons @osiewicz