-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ruby: Remove outline for running tests (#12642)
Hi, this pull request superseeds the #12624 and removes queries for runnables from `outline.scm`. This pull request has couple things to mention: - Removed task for running tests with `minitest` as I think it's not reliable in its state because, AFAIK, the only way to run `minitest` with the specific line, i.e. `bundle exec rake test spec/models/some_model.rb:12` is to use it with Rails. The support for `minitest` is still there and users can add their own task, for instance, when they use `minitest` in Rails to get support for running tests: ```json { "label": "test $ZED_RELATIVE_FILE:$ZED_ROW", "command": "./bin/rails", "args": ["test", "\"$ZED_RELATIVE_FILE:$ZED_ROW\""], "tags": ["minitest-test"] } ``` **Question:** Perhaps that should be mentioned in the Ruby extension documentation? - Adjusted runnables queries to work without `ZED_SYMBOL`. Release Notes: - N/A
- Loading branch information
Showing
3 changed files
with
13 additions
and
35 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,8 @@ | ||
[ | ||
{ | ||
"label": "test $ZED_SYMBOL", | ||
"command": "ruby", | ||
"args": ["-Itest", "$ZED_FILE", "--name", "\"/$ZED_SYMBOL/\""], | ||
"tags": ["minitest-test"] | ||
}, | ||
{ | ||
"label": "rspec $ZED_SYMBOL", | ||
"label": "rspec $ZED_RELATIVE_FILE:$ZED_ROW", | ||
"command": "./bin/rspec", | ||
"args": ["\"$ZED_FILE:$ZED_ROW\""], | ||
"args": ["\"$ZED_RELATIVE_FILE:$ZED_ROW\""], | ||
"tags": ["rspec-test"] | ||
} | ||
] |