update: remove dsp with v1(tekton)backend related code (opendatahub-i…

…o#1281) * update: remove dsp with v1(tekton)backend related code - images - tekton rbac - descriptions Signed-off-by: Wen Zhou <[email protected]> Co-authored-by: Humair Khan <[email protected]> --------- Signed-off-by: Wen Zhou <[email protected]> Co-authored-by: Humair Khan <[email protected]>
zdtsw-forking · Oct 27, 2024 · 133b710 · 133b710
1 parent bde4b4e
commit 133b710
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 52 deletions.
diff --git a/bundle/manifests/opendatahub-operator.clusterserviceversion.yaml b/bundle/manifests/opendatahub-operator.clusterserviceversion.yaml
@@ -175,11 +175,11 @@ spec:
     built on top of Kubeflow Notebook Controller with support for OAuth\n* Jupyter
     Notebooks - JupyterLab notebook that provide Python support for GPU workloads\n*
     Data Science Pipelines - Pipeline solution for end to end MLOps workflows that
-    support the Kubeflow Pipelines SDK and Tekton\n* Model Mesh - ModelMesh Serving
-    is the Controller for managing ModelMesh, a general-purpose model serving management/routing
-    layer\n* Distributed Workloads(Incubation) - Stack built to make managing distributed
-    compute infrastructure in the cloud easy and intuitive for Data Scientists. This
-    stack consists of three components \n                                      Codeflare
+    support the Kubeflow Pipelines SDK and Argo Workflows\n* Model Mesh - ModelMesh
+    Serving is the Controller for managing ModelMesh, a general-purpose model serving
+    management/routing layer\n* Distributed Workloads(Incubation) - Stack built to
+    make managing distributed compute infrastructure in the cloud easy and intuitive
+    for Data Scientists. This stack consists of three components \n                                      Codeflare
     , KubeRay and Kueue.\n* Kserve - Kserve is the Controller for for serving machine
     learning (ML) models on arbitrary frameworks"
   displayName: Open Data Hub Operator
@@ -491,12 +491,6 @@ spec:
           - patch
           - update
           - watch
-        - apiGroups:
-          - custom.tekton.dev
-          resources:
-          - pipelineloops
-          verbs:
-          - '*'
         - apiGroups:
           - dashboard.opendatahub.io
           resources:
@@ -1024,12 +1018,6 @@ spec:
           - delete
           - get
           - patch
-        - apiGroups:
-          - tekton.dev
-          resources:
-          - '*'
-          verbs:
-          - '*'
         - apiGroups:
           - template.openshift.io
           resources:

diff --git a/components/datasciencepipelines/datasciencepipelines.go b/components/datasciencepipelines/datasciencepipelines.go
@@ -1,5 +1,5 @@
 // Package datasciencepipelines provides utility functions to config Data Science Pipelines:
-// Pipeline solution for end to end MLOps workflows that support the Kubeflow Pipelines SDK, Tekton and Argo Workflows.
+// Pipeline solution for end to end MLOps workflows that support the Kubeflow Pipelines SDK and Argo Workflows.
 // +groupName=datasciencecluster.opendatahub.io
 package datasciencepipelines
 
@@ -45,22 +45,15 @@ func (d *DataSciencePipelines) Init(ctx context.Context, _ cluster.Platform) err
 	log := logf.FromContext(ctx).WithName(ComponentName)
 
 	var imageParamMap = map[string]string{
-		// v1
-		"IMAGES_APISERVER":         "RELATED_IMAGE_ODH_ML_PIPELINES_API_SERVER_IMAGE",
-		"IMAGES_ARTIFACT":          "RELATED_IMAGE_ODH_ML_PIPELINES_ARTIFACT_MANAGER_IMAGE",
-		"IMAGES_PERSISTENTAGENT":   "RELATED_IMAGE_ODH_ML_PIPELINES_PERSISTENCEAGENT_IMAGE",
-		"IMAGES_SCHEDULEDWORKFLOW": "RELATED_IMAGE_ODH_ML_PIPELINES_SCHEDULEDWORKFLOW_IMAGE",
-		"IMAGES_CACHE":             "RELATED_IMAGE_ODH_ML_PIPELINES_CACHE_IMAGE",
-		"IMAGES_DSPO":              "RELATED_IMAGE_ODH_DATA_SCIENCE_PIPELINES_OPERATOR_CONTROLLER_IMAGE",
-		// v2
-		"IMAGESV2_ARGO_APISERVER":          "RELATED_IMAGE_ODH_ML_PIPELINES_API_SERVER_V2_IMAGE",
-		"IMAGESV2_ARGO_PERSISTENCEAGENT":   "RELATED_IMAGE_ODH_ML_PIPELINES_PERSISTENCEAGENT_V2_IMAGE",
-		"IMAGESV2_ARGO_SCHEDULEDWORKFLOW":  "RELATED_IMAGE_ODH_ML_PIPELINES_SCHEDULEDWORKFLOW_V2_IMAGE",
-		"IMAGESV2_ARGO_ARGOEXEC":           "RELATED_IMAGE_ODH_DATA_SCIENCE_PIPELINES_ARGO_ARGOEXEC_IMAGE",
-		"IMAGESV2_ARGO_WORKFLOWCONTROLLER": "RELATED_IMAGE_ODH_DATA_SCIENCE_PIPELINES_ARGO_WORKFLOWCONTROLLER_IMAGE",
-		"V2_DRIVER_IMAGE":                  "RELATED_IMAGE_ODH_ML_PIPELINES_DRIVER_IMAGE",
-		"V2_LAUNCHER_IMAGE":                "RELATED_IMAGE_ODH_ML_PIPELINES_LAUNCHER_IMAGE",
-		"IMAGESV2_ARGO_MLMDGRPC":           "RELATED_IMAGE_ODH_MLMD_GRPC_SERVER_IMAGE",
+		"IMAGES_DSPO":                    "RELATED_IMAGE_ODH_DATA_SCIENCE_PIPELINES_OPERATOR_CONTROLLER_IMAGE",
+		"IMAGES_APISERVER":               "RELATED_IMAGE_ODH_ML_PIPELINES_API_SERVER_V2_IMAGE",
+		"IMAGES_PERSISTENCEAGENT":        "RELATED_IMAGE_ODH_ML_PIPELINES_PERSISTENCEAGENT_V2_IMAGE",
+		"IMAGES_SCHEDULEDWORKFLOW":       "RELATED_IMAGE_ODH_ML_PIPELINES_SCHEDULEDWORKFLOW_V2_IMAGE",
+		"IMAGES_ARGO_EXEC":               "RELATED_IMAGE_ODH_DATA_SCIENCE_PIPELINES_ARGO_ARGOEXEC_IMAGE",
+		"IMAGES_ARGO_WORKFLOWCONTROLLER": "RELATED_IMAGE_ODH_DATA_SCIENCE_PIPELINES_ARGO_WORKFLOWCONTROLLER_IMAGE",
+		"IMAGES_DRIVER":                  "RELATED_IMAGE_ODH_ML_PIPELINES_DRIVER_IMAGE",
+		"IMAGES_LAUNCHER":                "RELATED_IMAGE_ODH_ML_PIPELINES_LAUNCHER_IMAGE",
+		"IMAGES_MLMDGRPC":                "RELATED_IMAGE_ODH_MLMD_GRPC_SERVER_IMAGE",
 	}
 
 	if err := deploy.ApplyParams(Path, imageParamMap); err != nil {

diff --git a/config/manifests/description-patch.yml b/config/manifests/description-patch.yml
@@ -13,7 +13,7 @@ spec:
     * Open Data Hub Dashboard - A web dashboard that displays installed Open Data Hub components with easy access to component UIs and documentation
     * ODH Notebook Controller - Secure management of Jupyter Notebook in Kubernetes environments built on top of Kubeflow Notebook Controller with support for OAuth
     * Jupyter Notebooks - JupyterLab notebook that provide Python support for GPU workloads
-    * Data Science Pipelines - Pipeline solution for end to end MLOps workflows that support the Kubeflow Pipelines SDK and Tekton
+    * Data Science Pipelines - Pipeline solution for end to end MLOps workflows that support the Kubeflow Pipelines SDK and Argo Workflows
     * Model Mesh - ModelMesh Serving is the Controller for managing ModelMesh, a general-purpose model serving management/routing layer
     * Distributed Workloads(Incubation) - Stack built to make managing distributed compute infrastructure in the cloud easy and intuitive for Data Scientists. This stack consists of three components 
                                           Codeflare , KubeRay and Kueue.

diff --git a/config/rbac/role.yaml b/config/rbac/role.yaml
@@ -305,12 +305,6 @@ rules:
   - patch
   - update
   - watch
-- apiGroups:
-  - custom.tekton.dev
-  resources:
-  - pipelineloops
-  verbs:
-  - '*'
 - apiGroups:
   - dashboard.opendatahub.io
   resources:
@@ -838,12 +832,6 @@ rules:
   - delete
   - get
   - patch
-- apiGroups:
-  - tekton.dev
-  resources:
-  - '*'
-  verbs:
-  - '*'
 - apiGroups:
   - template.openshift.io
   resources:

diff --git a/controllers/datasciencecluster/kubebuilder_rbac.go b/controllers/datasciencecluster/kubebuilder_rbac.go
@@ -52,8 +52,6 @@ package datasciencecluster
 
 // +kubebuilder:rbac:groups="template.openshift.io",resources=templates,verbs=*
 
-// +kubebuilder:rbac:groups="tekton.dev",resources=*,verbs=*
-
 // +kubebuilder:rbac:groups="snapshot.storage.k8s.io",resources=volumesnapshots,verbs=create;delete;patch;get
 
 // +kubebuilder:rbac:groups="serving.kserve.io",resources=trainedmodels/status,verbs=update;patch;delete;get
@@ -151,8 +149,6 @@ package datasciencecluster
 // +kubebuilder:rbac:groups="extensions",resources=replicasets,verbs=*
 // +kubebuilder:rbac:groups="extensions",resources=ingresses,verbs=list;watch;patch;delete;get
 
-// +kubebuilder:rbac:groups="custom.tekton.dev",resources=pipelineloops,verbs=*
-
 // +kubebuilder:rbac:groups="core",resources=services/finalizers,verbs=create;delete;list;update;watch;patch;get
 // +kubebuilder:rbac:groups="core",resources=services,verbs=get;create;watch;update;patch;list;delete
 // +kubebuilder:rbac:groups="core",resources=services,verbs=*

diff --git a/docs/api-overview.md b/docs/api-overview.md
@@ -126,7 +126,7 @@ _Appears in:_
 ## datasciencecluster.opendatahub.io/datasciencepipelines
 
 Package datasciencepipelines provides utility functions to config Data Science Pipelines:
-Pipeline solution for end to end MLOps workflows that support the Kubeflow Pipelines SDK, Tekton and Argo Workflows.
+Pipeline solution for end to end MLOps workflows that support the Kubeflow Pipelines SDK and Argo Workflows.