-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Second attempt to enable custom tree for 'zinit ls' command #190
Conversation
oof, this zshdocs bug is a doozy |
Whatever. Let the test fail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested it, but looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested it, but looks good to me
Enable users to specify the zinit ls command via ZINIT[LIST_COMMAND] and provide default commands for exa and tree. Prefer exa if it is installed.
Well, I managed to make it work by using a docker container used in https://github.com/nektos/act My conclusion is that there is something different between my macOS en_US.UTF-8 and the one used in the github actions containers. |
This PR shouldn't contain a massive docs update. That should already be on master. I don't have time to jump into debugging it but I won't merge it with an ~800 line addition diff |
@nbrown great job on getting this to pass |
Sorry for the large doc change, I don't know how you want to handle it but the two choices as I see it are minimal doc changes that don't pass the documentation check or a large change that passes the check. I'll gladly revert it to not pass that check if that's what is preferred. |
Yeah, let's keep the PR tight and drop the docs change. We'll get the docs test sorted out soon (maybe, idk -- no promises) but I'm fine with it failing here. |
This reverts commit e2043bf.
Done. I reverted the doc fix so it's now a minimal change. On the docs test, I'll leave some info on that bug. I think it primarily comes down to a sorting (collation) inconsistency between Linux and macOS/BSD based on my reading and testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check evaluates to true even though I have exa, but no tree.
Closing in favor of #221 due to lack of update on the PR. |
Enable users to specify the zinit ls command via ZINIT[LIST_COMMAND] and
provide default commands for exa and tree. Prefer exa if it is installed.
Addresses issue #170
I cherry-picked the original changes to a clean branch and then updated the docs to attempt to address the documentation action issues.