funcs/element: fix panic when used with negative index #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a check for a negative index to both Type Impl functions, and some basic tests.
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
==========================================
+ Coverage 70.71% 70.90% +0.19%
==========================================
Files 79 79
Lines 7178 7184 +6
==========================================
+ Hits 5076 5094 +18
+ Misses 1661 1645 -16
- Partials 441 445 +4
Continue to review full report at Codecov.
|
mildwonkey
force-pushed
the
mildwonkey/b-element-panic
branch
from
526eb9c
to
53e2169
Compare
|
Nice! Thanks for fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check for a negative index to both Type Impl functions, and
some basic tests.
Downstream issue reference: hashicorp/terraform#25775