cty: AsBigFloat does a shallow copy #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbardin
force-pushed
the
as-big-float-copy
branch
2 times, most recently
from
5ad49d7
to
6930289
Compare
Use Float.Copy in AsBigFloat to ensure that there is no shared data between the mutable `*big.Float` and the `cty.Value` internal state.
jbardin
force-pushed
the
as-big-float-copy
branch
from
6930289
to
5e36dac
Compare
apparentlymart
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Float.CopyinAsBigFloatto ensure that there is no shared databetween the mutable
*big.Floatand thecty.Valueinternal state.Without the Copy, the given test will output: