-
-
Notifications
You must be signed in to change notification settings - Fork 73
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove all of the encoding/gob support code
I originally introduced all of this here as a concession to trying to HashiCorp trying to get cty values to round-trip through the various very magical gob-based wire interfaces in Terraform v0.11 and earlier, back when they thought cty and what became "HCL 2" would just be a drop-in replacement for HCL 1 and the various different competing representations of dynamic values. However, in practice none of that ever actually worked out and instead Terraform now natively uses cty JSON/msgpack and other such mechanisms for its wire protocols, making this gob handling code redundant. This stuff caused various maintenance headaches and panic bugs which make them a burden to retain. Although this is technically a breaking change to the public cty API, in practice this stuff was only here to allow Terraform to use it _indirectly_ as a side-effect of passing values into the encoding/gob package, and so I'm treating it as if it had been an internal implementation detail even though in principle it could've been depended on externally. If anyone was doing that, I'm sorry; I suggest copying the relevant support code into your own package instead if you wish to continue using cty with gob.
- Loading branch information
1 parent
65ead44
commit 97bafac
Showing
6 changed files
with
9 additions
and
423 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.