cty: NilType.Equals(...) without a panic

zclconf · Nov 10, 2020 · 1338293 · 1338293
1 parent 3293c1b
commit 1338293
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/cty/type.go b/cty/type.go
@@ -36,6 +36,9 @@ func (t typeImplSigil) isTypeImpl() typeImplSigil {
 // Equals returns true if the other given Type exactly equals the receiver
 // type.
 func (t Type) Equals(other Type) bool {
+	if t == NilType || other == NilType {
+		return t == other
+	}
 	return t.typeImpl.Equals(other)
 }
 

diff --git a/cty/type_test.go b/cty/type_test.go
@@ -54,3 +54,10 @@ func TestHasDynamicTypes(t *testing.T) {
 		})
 	}
 }
+
+func TestNilTypeEquals(t *testing.T) {
+	var typ Type
+	if !typ.Equals(NilType) {
+		t.Fatal("expected NilTypes to equal")
+	}
+}