Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use the ff 0.13 dependency stack. #6500

Merged
merged 4 commits into from
Apr 4, 2023
Merged

Update to use the ff 0.13 dependency stack. #6500

merged 4 commits into from
Apr 4, 2023

Conversation

nuttycom
Copy link
Contributor

No description provided.

@nuttycom nuttycom added safe-to-build Used to send PR to prod CI environment A-dependencies Area: Dependencies labels Mar 20, 2023
@nuttycom nuttycom removed the safe-to-build Used to send PR to prod CI environment label Mar 20, 2023
daira
daira reviewed Mar 20, 2023
View reviewed changes
.cargo/config.offline Outdated Show resolved Hide resolved
daira
daira reviewed Mar 20, 2023
View reviewed changes
Cargo.lock Outdated Show resolved Hide resolved
daira
daira reviewed Mar 20, 2023
View reviewed changes
Cargo.lock Outdated Show resolved Hide resolved
daira
daira requested changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update redjubjub, to avoid still depending on the old versions of bls12_382, ff, and group.

@nuttycom
Copy link
Contributor Author

Please update redjubjub, to avoid still depending on the old versions of bls12_382, ff, and group.

redjubjub doesn't have a release that depends upon the updated reddsa.

@daira daira added the safe-to-build Used to send PR to prod CI environment label Mar 20, 2023
@daira
Copy link
Contributor

daira commented Mar 20, 2023

Also there are some unvetted dependencies.

@daira
Copy link
Contributor

daira commented Mar 20, 2023

Filed ZcashFoundation/redjubjub#160

@ECC-CI ECC-CI removed the safe-to-build Used to send PR to prod CI environment label Mar 21, 2023
@nuttycom nuttycom force-pushed the upgrade/ff_0.13 branch 5 times, most recently from d224cfd to cf5360a Compare March 30, 2023 21:06
@nuttycom nuttycom requested a review from daira March 30, 2023 21:06
@nuttycom nuttycom added safe-to-build Used to send PR to prod CI environment and removed safe-to-build Used to send PR to prod CI environment labels Mar 30, 2023
@ECC-CI ECC-CI removed the safe-to-build Used to send PR to prod CI environment label Mar 30, 2023
@nuttycom nuttycom added the safe-to-build Used to send PR to prod CI environment label Mar 31, 2023
@ECC-CI ECC-CI removed the safe-to-build Used to send PR to prod CI environment label Mar 31, 2023
@nuttycom nuttycom force-pushed the upgrade/ff_0.13 branch 2 times, most recently from a2767e6 to 8c0e610 Compare March 31, 2023 19:44
@nuttycom nuttycom added the safe-to-build Used to send PR to prod CI environment label Mar 31, 2023
@ECC-CI ECC-CI removed the safe-to-build Used to send PR to prod CI environment label Mar 31, 2023
daira
daira reviewed Apr 1, 2023
View reviewed changes
Cargo.lock Outdated Show resolved Hide resolved
daira
daira previously approved these changes Apr 1, 2023
View reviewed changes
Copy link
Contributor

@daira daira left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK modulo cargo vet failures.

@nuttycom
Copy link
Contributor Author

nuttycom commented Apr 1, 2023

The cargo vet issues will be addressed later, when we remove all the patch versions prior to release.

@nuttycom nuttycom added the safe-to-build Used to send PR to prod CI environment label Apr 3, 2023
@ECC-CI ECC-CI removed the safe-to-build Used to send PR to prod CI environment label Apr 3, 2023
@nuttycom nuttycom added the safe-to-build Used to send PR to prod CI environment label Apr 3, 2023
@nuttycom nuttycom added safe-to-build Used to send PR to prod CI environment and removed safe-to-build Used to send PR to prod CI environment labels Apr 3, 2023
@daira daira mentioned this pull request Apr 3, 2023
Closed
@ECC-CI ECC-CI removed the safe-to-build Used to send PR to prod CI environment label Apr 3, 2023
daira added 2 commits April 4, 2023 02:06
@daira
cargo update
ff49b81 
Signed-off-by: Daira Emma Hopwood <[email protected]>
@daira
Add audits for updates to futures-* 0.3.28 and redjubjub 0.7.0.
d55d12d 
Signed-off-by: Daira Emma Hopwood <[email protected]>
@daira daira added the safe-to-build Used to send PR to prod CI environment label Apr 4, 2023
daira
daira approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@daira daira left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for the first two commits. I cannot review the last two commits because I wrote them.

@ECC-CI ECC-CI removed safe-to-build Used to send PR to prod CI environment labels Apr 4, 2023
nuttycom
nuttycom commented Apr 4, 2023
View reviewed changes
Copy link
Contributor Author

@nuttycom nuttycom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK ff49b81 and d55d12d.

@nuttycom
Copy link
Contributor Author

nuttycom commented Apr 4, 2023

Additional cargo vet failures will be fixed before release.

@nuttycom nuttycom merged commit 3c4dbf8 into zcash:master Apr 4, 2023
@nuttycom nuttycom deleted the upgrade/ff_0.13 branch April 4, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daira daira daira approved these changes

Assignees
No one assigned
Labels
A-dependencies Area: Dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nuttycom @daira @ECC-CI @ebfull