Skip to content

Implement no_std support via a default-enabled std feature flag. #209

Implement no_std support via a default-enabled std feature flag.

Implement no_std support via a default-enabled std feature flag. #209

GitHub Actions / Clippy: Rust Stable 1.65.0 (897e37553 2022-11-02) in failed Dec 18, 2024 in 1m 13s

Clippy (Stable ~ Linux/x86_64)

Clippy failed.

Details

Running cargo clippy took roughly ~72300ms to complete

  • Working Directory: repository directory

Annotations

Check failure on line 196 in /home/runner/work/sapling-crypto/sapling-crypto/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy: Rust Stable 1.65.0 (897e37553 2022-11-02) in

/home/runner/work/sapling-crypto/sapling-crypto/src/lib.rs#L196

this expression borrows a value the compiler would automatically borrow
Raw output
error: this expression borrows a value the compiler would automatically borrow
   --> src/note_encryption.rs:196:9
    |
196 |         (&mut input[12..20]).copy_from_slice(&note.value().inner().to_le_bytes());
    |         ^^^^^^^^^^^^^^^^^^^^ help: change this to: `input[12..20]`
    |
    = note: `-D clippy::needless-borrow` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check failure on line 88 in /home/runner/work/sapling-crypto/sapling-crypto/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy: Rust Stable 1.65.0 (897e37553 2022-11-02) in

/home/runner/work/sapling-crypto/sapling-crypto/src/lib.rs#L88

this expression creates a reference which is immediately dereferenced by the compiler
Raw output
error: this expression creates a reference which is immediately dereferenced by the compiler
  --> src/pedersen_hash.rs:88:13
   |
88 |             &generators.next().expect("we don't have enough generators");
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `generators.next().expect("we don't have enough generators")`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow