Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix Codecov check #989

Merged
merged 1 commit into from
Oct 2, 2023
Merged

CI: Fix Codecov check #989

merged 1 commit into from
Oct 2, 2023

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Sep 22, 2023

cargo tarpaulin has changed the case of one of its config options.

@str4d str4d marked this pull request as draft September 22, 2023 22:28
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Attention: 282 lines in your changes are missing coverage. Please review.

Files Coverage Δ
zcash_client_backend/src/data_api/scanning.rs 82.85% <ø> (ø)
zcash_client_backend/src/data_api/wallet.rs 88.70% <100.00%> (+2.14%) ⬆️
zcash_client_backend/src/proto/service.rs 0.00% <ø> (ø)
zcash_client_backend/src/scanning.rs 39.00% <ø> (-0.61%) ⬇️
...cash_client_backend/src/serialization/shardtree.rs 63.82% <ø> (ø)
zcash_client_sqlite/src/chain.rs 49.58% <ø> (ø)
zcash_client_sqlite/src/wallet/init.rs 47.22% <ø> (ø)
zcash_client_sqlite/src/wallet/init/migrations.rs 100.00% <100.00%> (ø)
...rc/wallet/init/migrations/add_transaction_views.rs 61.40% <ø> (ø)
...ite/src/wallet/init/migrations/add_utxo_account.rs 64.51% <ø> (ø)
... and 31 more

... and 6 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@nuttycom nuttycom deleted the branch main September 25, 2023 23:10
@nuttycom nuttycom closed this Sep 25, 2023
@str4d str4d reopened this Sep 26, 2023
@str4d str4d changed the base branch from release-lwsdk-2.0.0 to main September 26, 2023 23:03
`cargo tarpaulin` has changed the case of one of its config options.
@str4d
Copy link
Contributor Author

str4d commented Sep 27, 2023

One of the Codecov jobs succeeded, the other failed. I think the failure is due to the 10 minute timeout on building perhaps? Gonna try bumping that.

@str4d str4d marked this pull request as ready for review September 27, 2023 14:15
@str4d
Copy link
Contributor Author

str4d commented Sep 27, 2023

Hmm, this time both Codecov runs failed, so the timeout isn't the issue. The error I saw before is now shown in both of them, which I thought was cargo-tarpaulin killing the build:

error: could not compile `zcash_client_sqlite`

Caused by:
  process didn't exit successfully: `rustc --crate-name zcash_client_sqlite --edition=2021 zcash_client_sqlite/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --emit=dep-info,link -C opt-level=3 -C lto -C codegen-units=1 --test --cfg 'feature="default"' --cfg 'feature="hdwallet"' --cfg 'feature="mainnet"' --cfg 'feature="multicore"' --cfg 'feature="test-dependencies"' --cfg 'feature="transparent-inputs"' --cfg 'feature="unstable"' -C metadata=1e75df5b4eb915a0 -C extra-filename=-1e75df5b4eb915a0 --out-dir /__w/librustzcash/librustzcash/target/release/deps -L dependency=/__w/librustzcash/librustzcash/target/release/deps --extern assert_matches=/__w/librustzcash/librustzcash/target/release/deps/libassert_matches-efe2487f9fbcc73b.rlib --extern bs58=/__w/librustzcash/librustzcash/target/release/deps/libbs58-541e86e8fb9b8617.rlib --extern byteorder=/__w/librustzcash/librustzcash/target/release/deps/libbyteorder-5edbc0542050021f.rlib --extern group=/__w/librustzcash/librustzcash/target/release/deps/libgroup-82c185642eebf2ff.rlib --extern hdwallet=/__w/librustzcash/librustzcash/target/release/deps/libhdwallet-71bbc3d9b7fa46d1.rlib --extern incrementalmerkletree=/__w/librustzcash/librustzcash/target/release/deps/libincrementalmerkletree-a144dc12f0e2ef8e.rlib --extern jubjub=/__w/librustzcash/librustzcash/target/release/deps/libjubjub-67a27e91f8b94735.rlib --extern maybe_rayon=/__w/librustzcash/librustzcash/target/release/deps/libmaybe_rayon-349f10931d4fb6b7.rlib --extern proptest=/__w/librustzcash/librustzcash/target/release/deps/libproptest-1e57b3dd3517f0c5.rlib --extern prost=/__w/librustzcash/librustzcash/target/release/deps/libprost-cfdfae8f630af7bb.rlib --extern rand_core=/__w/librustzcash/librustzcash/target/release/deps/librand_core-a3ba67215af8fb9c.rlib --extern regex=/__w/librustzcash/librustzcash/target/release/deps/libregex-f09daf7d0af2be08.rlib --extern rusqlite=/__w/librustzcash/librustzcash/target/release/deps/librusqlite-0c763188536769b4.rlib --extern schemer=/__w/librustzcash/librustzcash/target/release/deps/libschemer-109d79cc70c8f6c2.rlib --extern schemer_rusqlite=/__w/librustzcash/librustzcash/target/release/deps/libschemer_rusqlite-f9ce9dc318064ac3.rlib --extern secrecy=/__w/librustzcash/librustzcash/target/release/deps/libsecrecy-7531036406fbae47.rlib --extern shardtree=/__w/librustzcash/librustzcash/target/release/deps/libshardtree-dd8d45abace544f1.rlib --extern tempfile=/__w/librustzcash/librustzcash/target/release/deps/libtempfile-b3b62a7aa0efcda1.rlib --extern time=/__w/librustzcash/librustzcash/target/release/deps/libtime-8d3e43a6d9f6caef.rlib --extern tracing=/__w/librustzcash/librustzcash/target/release/deps/libtracing-ec63afcdb1f353de.rlib --extern uuid=/__w/librustzcash/librustzcash/target/release/deps/libuuid-caf82da3406d0dc4.rlib --extern zcash_address=/__w/librustzcash/librustzcash/target/release/deps/libzcash_address-e55c9b342acdfcd6.rlib --extern zcash_client_backend=/__w/librustzcash/librustzcash/target/release/deps/libzcash_client_backend-d3cb09b05f8153c3.rlib --extern zcash_encoding=/__w/librustzcash/librustzcash/target/release/deps/libzcash_encoding-d720f3d2c4aa1fd5.rlib --extern zcash_note_encryption=/__w/librustzcash/librustzcash/target/release/deps/libzcash_note_encryption-3328f8bc6ede1a30.rlib --extern zcash_primitives=/__w/librustzcash/librustzcash/target/release/deps/libzcash_primitives-a5c6a8240339c0f4.rlib --extern zcash_proofs=/__w/librustzcash/librustzcash/target/release/deps/libzcash_proofs-1e016146ea7134ce.rlib -Cdebuginfo=2 --cfg=tarpaulin -Cdebug-assertions=off -Cinstrument-coverage -Clink-dead-code -L native=/__w/librustzcash/librustzcash/target/release/build/ring-d267965954a01c4f/out -L native=/__w/librustzcash/librustzcash/target/release/build/secp256k1-sys-945108c353cd4423/out -L native=/__w/librustzcash/librustzcash/target/release/build/libsqlite3-sys-5869ac37ddcda390/out` (signal: 9, SIGKILL: kill)

@str4d
Copy link
Contributor Author

str4d commented Oct 2, 2023

Based on google/oss-fuzz#10174 (comment), I believe the problem is more likely an OOM. Nothing we can really do about this without bumping the size of the GitHub Actions runner to one that costs money. So for now I'll remove the timeout commit and we can just merge the fix.

Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, modulo that this just clears the way for codecov to hit the next bug.

@nuttycom nuttycom merged commit 868d720 into main Oct 2, 2023
54 of 59 checks passed
@nuttycom nuttycom deleted the ci-fix-codecov branch October 2, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants