Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ZIP 321 parsing to use the MemoBytes type. #362

Merged
merged 3 commits into from
Mar 26, 2021

Conversation

nuttycom
Copy link
Contributor

This also adds documentation for the zip321 module.

@nuttycom nuttycom requested a review from str4d March 26, 2021 01:11
@str4d str4d force-pushed the cleanup/zip_321_memobytes branch from a850816 to fc3aa23 Compare March 26, 2021 01:47
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #362 (dd15e5f) into master (44e3176) will increase coverage by 0.37%.
The diff coverage is 83.33%.

❗ Current head dd15e5f differs from pull request most recent head f30502c. Consider uploading reports for the commit f30502c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
+ Coverage   64.49%   64.86%   +0.37%     
==========================================
  Files          70       70              
  Lines        7176     7152      -24     
==========================================
+ Hits         4628     4639      +11     
+ Misses       2548     2513      -35     
Impacted Files Coverage Δ
zcash_client_backend/src/zip321.rs 70.14% <83.33%> (+5.90%) ⬆️
zcash_primitives/src/memo.rs 47.36% <0.00%> (+8.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44e3176...f30502c. Read the comment docs.

@str4d str4d added this to the Core Sprint 2021-10 milestone Mar 26, 2021
zcash_client_backend/src/zip321.rs Outdated Show resolved Hide resolved
zcash_client_backend/src/zip321.rs Outdated Show resolved Hide resolved
zcash_client_backend/src/zip321.rs Outdated Show resolved Hide resolved
zcash_client_backend/src/zip321.rs Outdated Show resolved Hide resolved
zcash_client_backend/src/zip321.rs Outdated Show resolved Hide resolved
zcash_client_backend/src/zip321.rs Outdated Show resolved Hide resolved
zcash_client_backend/src/zip321.rs Outdated Show resolved Hide resolved
zcash_client_backend/src/zip321.rs Outdated Show resolved Hide resolved
zcash_client_backend/src/zip321.rs Outdated Show resolved Hide resolved
zcash_client_backend/src/zip321.rs Outdated Show resolved Hide resolved
@nuttycom nuttycom requested a review from str4d March 26, 2021 03:25
@str4d str4d merged commit a80fd59 into zcash:master Mar 26, 2021
@nuttycom nuttycom deleted the cleanup/zip_321_memobytes branch March 26, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants