Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.3.0 #278

Merged
merged 10 commits into from
Aug 24, 2020
Merged

Release 0.3.0 #278

merged 10 commits into from
Aug 24, 2020

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Aug 22, 2020

No description provided.

Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. Filed #279 for the lint warnings.

@codecov
Copy link

codecov bot commented Aug 22, 2020

Codecov Report

Merging #278 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #278      +/-   ##
==========================================
+ Coverage   66.03%   66.05%   +0.02%     
==========================================
  Files         101      101              
  Lines       13215    13217       +2     
==========================================
+ Hits         8726     8731       +5     
+ Misses       4489     4486       -3     
Impacted Files Coverage Δ
zcash_primitives/src/note_encryption.rs 77.29% <ø> (ø)
zcash_client_sqlite/src/chain.rs 92.10% <0.00%> (-1.32%) ⬇️
bellman/src/gadgets/blake2s.rs 94.66% <0.00%> (-0.47%) ⬇️
bls12_381/src/g1.rs 71.52% <0.00%> (ø)
bls12_381/src/g2.rs 69.04% <0.00%> (ø)
bellman/tests/mimc.rs 86.07% <0.00%> (ø)
bellman/src/groth16/tests/mod.rs 74.72% <0.00%> (ø)
zcash_proofs/src/circuit/sprout/input.rs 0.00% <0.00%> (ø)
zcash_primitives/src/merkle_tree.rs 62.59% <0.00%> (+0.14%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bfb935...3cd8f64. Read the comment docs.

@daira
Copy link
Contributor

daira commented Aug 22, 2020

warning: unresolved link to `SubgroupPoint::from_bytes`
##[warning]    --> jubjub/src/lib.rs:1032:27
     |
1032 |     /// other cases, use [`SubgroupPoint::from_bytes`] instead.
     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^ unresolved link
     |
     = note: `#[warn(broken_intra_doc_links)]` on by default
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`

I think that should be either [SubgroupPoint::from_bytes] or

[`SubgroupPoint::from_bytes`](SubgroupPoint::from_bytes)

@str4d
Copy link
Contributor Author

str4d commented Aug 22, 2020

The syntax there is correct. What's missing is an import, which I'll add shortly.

@ebfull
Copy link
Collaborator

ebfull commented Aug 22, 2020

There is a RELEASES.md file that I've been using to inform users of bls12_381 about the API changes. Can we update this PR with that?

@str4d
Copy link
Contributor Author

str4d commented Aug 23, 2020

@daira I fixed the intra-doc link in #281.

@ebfull once #281 is merged, I'll rebase this PR and then amend the bls12_381 and jubjub commits to also update their RELEASES.md files.

@str4d
Copy link
Contributor Author

str4d commented Aug 23, 2020

Rebased on master after merging #281. I'll edit the RELEASES.md files next.

@str4d
Copy link
Contributor Author

str4d commented Aug 23, 2020

Force-pushed to update the bls12_381 and jubjub release commits with release notes.

@str4d
Copy link
Contributor Author

str4d commented Aug 23, 2020

Aaand fixed some copy-pasta 🍝

Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ebfull
Copy link
Collaborator

ebfull commented Aug 24, 2020

ACK

@ebfull ebfull merged commit 50140c5 into zcash:master Aug 24, 2020
@str4d str4d deleted the release-0.3.0 branch August 24, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants