Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCZT improvements #1668

Merged
merged 2 commits into from
Dec 19, 2024
Merged

PCZT improvements #1668

merged 2 commits into from
Dec 19, 2024

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Dec 18, 2024

No description provided.

nuttycom
nuttycom previously approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 7202932 with typo correction

zcash_transparent/src/pczt.rs Outdated Show resolved Hide resolved
@str4d str4d force-pushed the pczt-improvements branch from 7202932 to 4b3d2bb Compare December 18, 2024 17:57
@str4d
Copy link
Contributor Author

str4d commented Dec 18, 2024

Force-pushed to fix typo.

nuttycom
nuttycom previously approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 4b3d2bb

@str4d str4d force-pushed the pczt-improvements branch from 4b3d2bb to 2bce3ce Compare December 18, 2024 18:37
nuttycom
nuttycom approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK 2bce3ce

@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 52.96%. Comparing base (02d18ec) to head (2bce3ce).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
zcash_transparent/src/pczt.rs 0.00% 17 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1668      +/-   ##
==========================================
- Coverage   53.01%   52.96%   -0.05%     
==========================================
  Files         175      175              
  Lines       21073    21090      +17     
==========================================
  Hits        11171    11171              
- Misses       9902     9919      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@str4d str4d merged commit eee19d9 into main Dec 19, 2024
30 of 32 checks passed
@str4d str4d deleted the pczt-improvements branch December 19, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuttycom nuttycom nuttycom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@str4d @nuttycom