-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move transparent protocol to zcash_transparent
crate
#1657
Conversation
Move-only on the relevant files; things are currently broken.
ee385a1
to
c4f64f6
Compare
110bc20
to
98a06b3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1657 +/- ##
=======================================
Coverage 52.97% 52.98%
=======================================
Files 173 175 +2
Lines 21046 21051 +5
=======================================
+ Hits 11149 11153 +4
- Misses 9897 9898 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK with API suggestions (pulling TxId up into zcash_protocol
is nonblocking but strongly recommended.)
ac7b668
to
1767240
Compare
Force-pushed to address review comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 1767240, looks great!
1767240
to
c85b12c
Compare
force-pushed to fix Clippy complaints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK c85b12c
c85b12c
to
e4915f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-utACK e4915f9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-utACK b1962ac
No description provided.