Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move transparent protocol to zcash_transparent crate #1657

Merged
merged 3 commits into from
Dec 15, 2024
Merged

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Dec 14, 2024

No description provided.

Base automatically changed from zcash_transparent-empty-crate to main December 14, 2024 14:46
Move-only on the relevant files; things are currently broken.
@str4d str4d force-pushed the zcash_transparent branch from ee385a1 to c4f64f6 Compare December 15, 2024 10:09
@str4d str4d marked this pull request as ready for review December 15, 2024 10:09
@str4d str4d force-pushed the zcash_transparent branch 2 times, most recently from 110bc20 to 98a06b3 Compare December 15, 2024 10:17
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

Attention: Patch coverage is 48.93617% with 48 lines in your changes missing coverage. Please review.

Project coverage is 52.98%. Comparing base (ff5ec14) to head (1767240).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
devtools/src/bin/inspect/transaction.rs 0.00% 12 Missing ⚠️
components/zcash_protocol/src/txid.rs 50.00% 10 Missing ⚠️
zcash_transparent/src/builder.rs 30.76% 9 Missing ⚠️
zcash_transparent/src/pczt/signer.rs 0.00% 9 Missing ⚠️
zcash_transparent/src/pczt/tx_extractor.rs 0.00% 6 Missing ⚠️
zcash_primitives/src/transaction/mod.rs 66.66% 1 Missing ⚠️
zcash_transparent/src/sighash.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1657   +/-   ##
=======================================
  Coverage   52.97%   52.98%           
=======================================
  Files         173      175    +2     
  Lines       21046    21051    +5     
=======================================
+ Hits        11149    11153    +4     
- Misses       9897     9898    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nuttycom
nuttycom previously approved these changes Dec 15, 2024
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK with API suggestions (pulling TxId up into zcash_protocol is nonblocking but strongly recommended.)

zcash_transparent/src/builder.rs Outdated Show resolved Hide resolved
zcash_transparent/src/bundle.rs Outdated Show resolved Hide resolved
@str4d str4d force-pushed the zcash_transparent branch 2 times, most recently from ac7b668 to 1767240 Compare December 15, 2024 17:59
@str4d
Copy link
Contributor Author

str4d commented Dec 15, 2024

Force-pushed to address review comments.

nuttycom
nuttycom previously approved these changes Dec 15, 2024
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 1767240, looks great!

@nuttycom
Copy link
Contributor

force-pushed to fix Clippy complaints.

nuttycom
nuttycom previously approved these changes Dec 15, 2024
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK c85b12c

nuttycom
nuttycom previously approved these changes Dec 15, 2024
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK e4915f9

Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK b1962ac

@nuttycom nuttycom merged commit 24833e7 into main Dec 15, 2024
59 checks passed
@nuttycom nuttycom deleted the zcash_transparent branch December 15, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants