Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zcash_client_sqlite: Verify that the database is for the correct network before (most) migrations. #1596

Conversation

nuttycom
Copy link
Contributor

No description provided.

@nuttycom nuttycom force-pushed the wallet/network_type_check branch from 4e30d75 to 6afa7b4 Compare October 29, 2024 17:37
@nuttycom nuttycom changed the base branch from main to hotfix/zcash_client_sqlite-0.12.x October 29, 2024 17:37
@nuttycom nuttycom force-pushed the wallet/network_type_check branch from 6afa7b4 to e24770d Compare October 29, 2024 17:42
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 57.50000% with 17 lines in your changes missing coverage. Please review.

Project coverage is 61.64%. Comparing base (69b590a) to head (e24770d).
Report is 4 commits behind head on hotfix/zcash_client_sqlite-0.12.x.

Files with missing lines Patch % Lines
zcash_client_sqlite/src/wallet/init/migrations.rs 66.66% 9 Missing ⚠️
zcash_client_sqlite/src/wallet/transparent.rs 0.00% 8 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                          @@
##           hotfix/zcash_client_sqlite-0.12.x    #1596      +/-   ##
=====================================================================
- Coverage                              61.65%   61.64%   -0.01%     
=====================================================================
  Files                                    148      148              
  Lines                                  18832    18868      +36     
=====================================================================
+ Hits                                   11610    11631      +21     
- Misses                                  7222     7237      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK e24770d

@nuttycom nuttycom merged commit 8733c47 into zcash:hotfix/zcash_client_sqlite-0.12.x Oct 29, 2024
25 of 27 checks passed
@nuttycom nuttycom deleted the wallet/network_type_check branch October 29, 2024 20:59
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-hoc ACK

@str4d str4d added the C-tracked-bug Category: This is a bug for which we are tracking deployment to apps. label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-tracked-bug Category: This is a bug for which we are tracking deployment to apps.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants