zcash_client_backend: Switch from async-trait to RPIT for tor module
#1595
+70
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RPIT (return-position `impl Trait`) was stabilized in Rust 1.75, and the `dynosaur` crate providing dynamic dispatch support was published two weeks ago. Now that our MSRV is 1.77, we can use both of these.
str4d
changed the title
async-trait to RPITasync-trait to RPIT for tor module
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1595 +/- ##
==========================================
- Coverage 56.31% 56.31% -0.01%
==========================================
Files 148 148
Lines 19026 19026
==========================================
- Hits 10715 10714 -1
- Misses 8311 8312 +1 ☔ View full report in Codecov by Sentry. |
daira
reviewed
Oct 26, 2024
| @@ -1,4 +1,3 @@ | |||
| use async_trait::async_trait; | |||
There was a problem hiding this comment.
Can this also be used to remove librustzcash's one remaining dependency on async_trait for data_api::chain::BlockCache?
There was a problem hiding this comment.
Ah you're way ahead of me, lol. #1535 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RPIT (return-position
impl Trait) was stabilized in Rust 1.75, and thedynosaurcrate providing dynamic dispatch support was published two weeks ago. Now that our MSRV is 1.77, we can use both of these.