Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add a job that runs when all required status checks pass #1594

Merged
merged 3 commits into from
Oct 26, 2024

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Oct 25, 2024

This enables us to add a single "required status check" to the GitHub repo settings, that covers all required matrix job cases.

nuttycom
nuttycom previously approved these changes Oct 25, 2024
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK e81ee7a

nuttycom
nuttycom previously approved these changes Oct 25, 2024
@str4d str4d force-pushed the ci-required-status-checks branch 3 times, most recently from e696aa0 to 5c24d65 Compare October 25, 2024 23:58
This enables us to add a single "required status check" to the GitHub
repo settings, that covers all required matrix job cases.
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 56fa0b8

@nuttycom nuttycom added this pull request to the merge queue Oct 26, 2024
Merged via the queue into main with commit 5edaa26 Oct 26, 2024
28 checks passed
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.31%. Comparing base (b78a91f) to head (56fa0b8).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1594   +/-   ##
=======================================
  Coverage   56.31%   56.31%           
=======================================
  Files         148      148           
  Lines       19026    19026           
=======================================
+ Hits        10714    10715    +1     
+ Misses       8312     8311    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@str4d str4d deleted the ci-required-status-checks branch October 26, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants