zcash_client_backend: Remove deprecated and duplicative wallet APIs. #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuttycom
force-pushed
the
wallet/remove_deprecated
branch
3 times, most recently
from
94694df to
0feafd9
Compare
nuttycom
commented
Oct 24, 2024
nuttycom
force-pushed
the
wallet/remove_deprecated
branch
from
0feafd9 to
0ce69fc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1590 +/- ##
==========================================
- Coverage 56.48% 56.31% -0.18%
==========================================
Files 150 148 -2
Lines 19126 19026 -100
==========================================
- Hits 10803 10714 -89
+ Misses 8323 8312 -11 ☔ View full report in Codecov by Sentry. |
…address` methods.
fixed fees are not standard), and deprecate `fixed::FeeRule::non_standard`. Signed-off-by: Daira-Emma Hopwood <[email protected]>
Co-authored-by: Daira-Emma Hopwood <[email protected]>
nuttycom
force-pushed
the
wallet/remove_deprecated
branch
from
0ce69fc to
f2b51cf
Compare
daira
reviewed
Oct 25, 2024
daira
reviewed
Oct 25, 2024
daira
reviewed
Oct 25, 2024
daira
reviewed
Oct 25, 2024
nuttycom
force-pushed
the
wallet/remove_deprecated
branch
from
2cc6775 to
d3b82ee
Compare
|
force-pushed to address comments from code review. |
daira
reviewed
Oct 25, 2024
Co-authored-by: Daira-Emma Hopwood <[email protected]>
nuttycom
force-pushed
the
wallet/remove_deprecated
branch
from
d3b82ee to
ae58d3e
Compare
nuttycom
dismissed
str4d’s stale review
All requested changelog fixes are complete.
|
Post-hoc utACK ae58d3e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reworking of nuttycom#40 that removes additional deprecated APIs and puts non-standard fee calculation capabilities behind a
non-standard-feesfeature flag.