-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zcash_client_sqlite: Ensure that all shielded change outputs are correctly flagged. #1585
Conversation
cacbf26
to
0d82e1e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1585 +/- ##
==========================================
+ Coverage 56.39% 56.48% +0.08%
==========================================
Files 149 150 +1
Lines 19078 19126 +48
==========================================
+ Hits 10759 10803 +44
- Misses 8319 8323 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 0d82e1e
zcash_client_sqlite/src/wallet/init/migrations/fix_bad_change_flagging.rs
Outdated
Show resolved
Hide resolved
zcash_client_sqlite/src/wallet/init/migrations/fix_bad_change_flagging.rs
Show resolved
Hide resolved
zcash_client_sqlite/src/wallet/init/migrations/fix_bad_change_flagging.rs
Show resolved
Hide resolved
…ash#1571 The update to a shielding transaction causes the information that the output is considered change to be lost. This happens because the scanning process does not have access to any information about the inputs to the transaction, and so it does not recognize the output as change.
…ic migration state.
0d82e1e
to
4a2a288
Compare
…scind that determination. This is a minimal and correct but incomplete fix for zcash#1571. Additional work to distinguish change outputs is necessary to update existing wallets that have made an incorrect change determination in the past.
…tly flagged when recording sent outputs. Fixes zcash#1571
bca02d5
to
d753090
Compare
force-pushed to address review comments then force-pushed to rebase on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK d753090
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Post-hoc ACK
Fixes #1571