-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump MSRV to 1.77 #1582
Bump MSRV to 1.77 #1582
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1582 +/- ##
==========================================
- Coverage 61.88% 55.94% -5.94%
==========================================
Files 149 149
Lines 18946 18728 -218
==========================================
- Hits 11724 10477 -1247
- Misses 7222 8251 +1029 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 9bf153d
@@ -2020,7 +2020,21 @@ pub(crate) fn block_fully_scanned<P: consensus::Parameters>( | |||
// | |||
// The fully-scanned height is therefore the last height that falls within the first range in | |||
// the scan queue with priority "Scanned". | |||
// SQL query problems. | |||
let calc_fully_scanned_height = |row: &rusqlite::Row| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is fine, but for my education what in the MSRV change prompted it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new lint is "in a match
scrutinee, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a let
".
https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_conditions
No description provided.