Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV to 1.77 #1582

Merged
merged 6 commits into from
Oct 23, 2024
Merged

Bump MSRV to 1.77 #1582

merged 6 commits into from
Oct 23, 2024

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Oct 18, 2024

No description provided.

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 60.52632% with 15 lines in your changes missing coverage. Please review.

Project coverage is 55.94%. Comparing base (bf8b39a) to head (9bf153d).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
zcash_client_backend/src/data_api/error.rs 0.00% 3 Missing ⚠️
zcash_client_backend/src/data_api/testing/pool.rs 0.00% 3 Missing ⚠️
components/zcash_protocol/src/value.rs 75.00% 2 Missing ⚠️
zcash_client_sqlite/src/lib.rs 33.33% 2 Missing ⚠️
zcash_client_sqlite/src/wallet.rs 77.77% 2 Missing ⚠️
...h_primitives/src/transaction/components/sapling.rs 0.00% 2 Missing ⚠️
zcash_primitives/src/legacy.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1582      +/-   ##
==========================================
- Coverage   61.88%   55.94%   -5.94%     
==========================================
  Files         149      149              
  Lines       18946    18728     -218     
==========================================
- Hits        11724    10477    -1247     
- Misses       7222     8251    +1029     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 9bf153d

@@ -2020,7 +2020,21 @@ pub(crate) fn block_fully_scanned<P: consensus::Parameters>(
//
// The fully-scanned height is therefore the last height that falls within the first range in
// the scan queue with priority "Scanned".
// SQL query problems.
let calc_fully_scanned_height = |row: &rusqlite::Row| {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is fine, but for my education what in the MSRV change prompted it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new lint is "in a match scrutinee, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a let".

https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_conditions

@nuttycom nuttycom merged commit 791b371 into main Oct 23, 2024
26 of 28 checks passed
@nuttycom nuttycom deleted the msrv-1.77 branch October 23, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants