zcash_client_backend: Generalize & extend wallet metadata query API #1580

nuttycom · 2024-10-17T19:41:12Z

No description provided.

This was a test.

codecov · 2024-11-01T18:55:40Z

Codecov Report

Attention: Patch coverage is 69.68504% with 77 lines in your changes missing coverage. Please review.

Project coverage is 56.38%. Comparing base (8b49ca8) to head (00cafa3).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
zcash_client_backend/src/data_api/testing/pool.rs	62.50%	21 Missing ⚠️
zcash_client_backend/src/data_api.rs	60.00%	20 Missing ⚠️
zcash_client_sqlite/src/wallet/common.rs	77.92%	17 Missing ⚠️
zcash_client_backend/src/fees.rs	66.66%	9 Missing ⚠️
zcash_client_sqlite/src/lib.rs	33.33%	6 Missing ⚠️
zcash_client_backend/src/fees/common.rs	71.42%	2 Missing ⚠️
zcash_client_backend/src/data_api/testing.rs	94.44%	1 Missing ⚠️
zcash_client_sqlite/src/error.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1580      +/-   ##
==========================================
+ Coverage   56.30%   56.38%   +0.07%     
==========================================
  Files         148      148              
  Lines       19062    19232     +170     
==========================================
+ Hits        10733    10844     +111     
- Misses       8329     8388      +59

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

str4d

Reviewed 530d06b

components/zcash_protocol/src/value.rs

zcash_client_backend/src/data_api.rs

zcash_client_sqlite/src/wallet/common.rs

zcash_client_backend/src/data_api.rs

zcash_client_sqlite/src/wallet/common.rs

This generalizes the previous account metadata query API to be able to represent more complex queries, and also to return note totals in addition to note counts.

nuttycom · 2024-11-13T20:22:43Z

force-pushed to address comments from code review.

str4d

utACK 3352671 after minor comments, Clippy lints, and rustfmt errors are fixed.

zcash_client_backend/src/fees.rs

zcash_client_sqlite/CHANGELOG.md

zcash_client_sqlite/src/error.rs

zcash_client_sqlite/src/wallet/common.rs

components/zcash_protocol/src/value.rs

Co-authored by: Jack Grig <[email protected]> Co-authored-by: Daira-Emma Hopwood <[email protected]>

str4d

Re-utACK 00cafa3

daira · 2024-11-24T01:25:15Z

zcash_client_backend/src/data_api/testing.rs

@@ -861,6 +863,49 @@ where
        + WalletCommitmentTrees,
    <DbT as WalletRead>::AccountId: ConditionallySelectable + Default + Send + 'static,
 {
+    // Creates a transaction that sends the specified value from the given account to
+    // the provided recipient address, using a greedy input selector and the default
+    // mutli-output change strategy.


daira · 2024-11-24T01:26:31Z

zcash_client_backend/src/data_api/testing/pool.rs

+
+    // Spend half of each one of our notes, so that we can get a distribution of sent note values.
+    // FIXME: This test is currently excessively specialized to the `zcash_client_sqlite::WalletDb`
+    // implmentation of the `InputSource` trait. A better approach would be to create a test input


daira

Post-hoc ACK. There are a couple of typos in comments.

nuttycom force-pushed the wallet/multi_output_dynamic_min_split branch 3 times, most recently from 98093e1 to 9ca4f50 Compare October 21, 2024 15:52

nuttycom force-pushed the wallet/multi_output_dynamic_min_split branch 2 times, most recently from cb12eb7 to 3fe1cdb Compare October 25, 2024 15:50

nuttycom marked this pull request as ready for review October 25, 2024 21:45

This comment was marked as outdated.

Sign in to view

nuttycom marked this pull request as draft October 26, 2024 22:53

nuttycom force-pushed the wallet/multi_output_dynamic_min_split branch 2 times, most recently from 37f993e to 600b5e6 Compare November 1, 2024 17:48

nuttycom changed the title ~~Wallet/multi output dynamic min split~~ zcash_client_backend: Generalize & extend wallet metadata query API Nov 1, 2024

nuttycom marked this pull request as ready for review November 1, 2024 17:49

daira mentioned this pull request Nov 2, 2024

Dev quality-of-life improvements (better test backtraces in CI and locally; faster test builds; RUST_BACKTRACE=1 by default) #1603

Merged

nuttycom force-pushed the wallet/multi_output_dynamic_min_split branch 3 times, most recently from e9ad4a6 to 530d06b Compare November 12, 2024 21:47

str4d requested changes Nov 13, 2024

View reviewed changes

nuttycom force-pushed the wallet/multi_output_dynamic_min_split branch from 530d06b to 8c95260 Compare November 13, 2024 18:16

nuttycom mentioned this pull request Nov 13, 2024

zcash_client_backend: Reduce the dependency of the metadata_queries_exclude_unwanted_notes test on zcash_client_sqlite behavior. #1613

Open

nuttycom requested a review from str4d November 13, 2024 18:26

zcash_client_backend: Generalize & extend account metadata query API

3352671

This generalizes the previous account metadata query API to be able to represent more complex queries, and also to return note totals in addition to note counts.

nuttycom force-pushed the wallet/multi_output_dynamic_min_split branch from 7dab03a to 3352671 Compare November 13, 2024 20:22

str4d previously approved these changes Nov 13, 2024

View reviewed changes

daira reviewed Nov 13, 2024

View reviewed changes

components/zcash_protocol/src/value.rs Outdated Show resolved Hide resolved

daira reviewed Nov 13, 2024

View reviewed changes

components/zcash_protocol/src/value.rs Outdated Show resolved Hide resolved

nuttycom dismissed str4d’s stale review via 8cef12f November 13, 2024 20:46

nuttycom force-pushed the wallet/multi_output_dynamic_min_split branch from b87558f to 01b0d1c Compare November 13, 2024 20:58

nuttycom requested review from daira and str4d November 13, 2024 21:00

Apply suggestions from code review & Clippy fixes.

00cafa3

Co-authored by: Jack Grig <[email protected]> Co-authored-by: Daira-Emma Hopwood <[email protected]>

nuttycom force-pushed the wallet/multi_output_dynamic_min_split branch from 01b0d1c to 00cafa3 Compare November 13, 2024 21:19

str4d approved these changes Nov 13, 2024

View reviewed changes

nuttycom added this pull request to the merge queue Nov 13, 2024

Merged via the queue into zcash:main with commit be4bc23 Nov 13, 2024
29 checks passed

nuttycom deleted the wallet/multi_output_dynamic_min_split branch November 13, 2024 23:25

nuttycom mentioned this pull request Nov 13, 2024

Passive note management #1355

Closed

daira reviewed Nov 24, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

zcash_client_backend: Generalize & extend wallet metadata query API #1580

zcash_client_backend: Generalize & extend wallet metadata query API #1580

nuttycom commented Oct 17, 2024

This comment was marked as outdated.

codecov bot commented Nov 1, 2024 •

edited

Loading

str4d left a comment

nuttycom commented Nov 13, 2024

str4d left a comment

str4d left a comment

daira Nov 24, 2024

daira Nov 24, 2024

daira left a comment

zcash_client_backend: Generalize & extend wallet metadata query API #1580

zcash_client_backend: Generalize & extend wallet metadata query API #1580

Conversation

nuttycom commented Oct 17, 2024

This comment was marked as outdated.

codecov bot commented Nov 1, 2024 • edited Loading

Codecov Report

str4d left a comment

Choose a reason for hiding this comment

nuttycom commented Nov 13, 2024

str4d left a comment

Choose a reason for hiding this comment

str4d left a comment

Choose a reason for hiding this comment

daira Nov 24, 2024

Choose a reason for hiding this comment

daira Nov 24, 2024

Choose a reason for hiding this comment

daira left a comment

Choose a reason for hiding this comment

codecov bot commented Nov 1, 2024 •

edited

Loading