-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the rusqlite
and arti-client
crates
#1578
Conversation
@@ -123,9 +123,9 @@ subtle = "2.2.3" | |||
# - Warning: One of the downstream consumers requires that SQLite be available through | |||
# CocoaPods, due to being bound to React Native. We need to ensure that the SQLite | |||
# version required for `rusqlite` is a version that is available through CocoaPods. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked and I believe our constraints here are met for all rusqlite
versions existing in this PR:
rusqlite | Bundled SQLite | Matching CocoaPods sqlite3 tag |
---|---|---|
0.29 | 3.41.2 | ✅ |
0.30 | 3.44.0 | ✅ |
0.31 | 3.45.1 | ✅ |
0.32 | 3.46.0 | ✅ |
f15f8a8
to
88d1736
Compare
Force-pushed to back out |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1578 +/- ##
=======================================
Coverage 61.64% 61.64%
=======================================
Files 148 148
Lines 18829 18829
=======================================
Hits 11608 11608
Misses 7221 7221 ☔ View full report in Codecov by Sentry. |
88d1736
to
8ff0b1a
Compare
Rebased on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 8ff0b1a - it's really nice to see all that reduction in duplicated dependencies!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love to see those deduplications of crypto crates <3. Post-hoc ACK.
This was previously blocked on
schemer
, because we cannot have two different versions of thelibsqlite3-sys
crate in our dependency tree. After switching toschemerz
in #1575, we can now update these in sync.