Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the rusqlite and arti-client crates #1578

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Update the rusqlite and arti-client crates #1578

merged 3 commits into from
Oct 17, 2024

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Oct 16, 2024

This was previously blocked on schemer, because we cannot have two different versions of the libsqlite3-sys crate in our dependency tree. After switching to schemerz in #1575, we can now update these in sync.

@@ -123,9 +123,9 @@ subtle = "2.2.3"
# - Warning: One of the downstream consumers requires that SQLite be available through
# CocoaPods, due to being bound to React Native. We need to ensure that the SQLite
# version required for `rusqlite` is a version that is available through CocoaPods.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked and I believe our constraints here are met for all rusqlite versions existing in this PR:

rusqlite Bundled SQLite Matching CocoaPods sqlite3 tag
0.29 3.41.2
0.30 3.44.0
0.31 3.45.1
0.32 3.46.0

@str4d
Copy link
Contributor Author

str4d commented Oct 16, 2024

Force-pushed to back out rusqlite 0.32 from this PR. It requires MSRV 1.77, which I think would be reasonable, but not in this PR (I'd make a separate PR for that, once we've determined that getting as far as rusqlite 0.31 is fine).

@str4d
Copy link
Contributor Author

str4d commented Oct 16, 2024

cargo vet will fail because I haven't updated the audits for the dependency changes. I'll force-push with those changes later.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.64%. Comparing base (3d6b6e8) to head (8ff0b1a).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1578   +/-   ##
=======================================
  Coverage   61.64%   61.64%           
=======================================
  Files         148      148           
  Lines       18829    18829           
=======================================
  Hits        11608    11608           
  Misses       7221     7221           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@str4d str4d marked this pull request as ready for review October 17, 2024 21:05
@str4d
Copy link
Contributor Author

str4d commented Oct 17, 2024

Rebased on main to fix merge conflicts, and fixed lints.

Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 8ff0b1a - it's really nice to see all that reduction in duplicated dependencies!

@str4d str4d merged commit 09b4d92 into main Oct 17, 2024
28 checks passed
@str4d str4d deleted the rusqlite-updates branch October 17, 2024 21:37
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see those deduplications of crypto crates <3. Post-hoc ACK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants