Make transparent tests generic over backend implementation and move to zcash_client_backend crate
#1576
+250
−248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willemolding
commented
Oct 16, 2024
Comment on lines
-938
to
-949
| // Artificially delete the address from the addresses table so that | ||
| // we can ensure the update fails if the join doesn't work. | ||
| st.wallet() | ||
| .conn() | ||
| .execute( | ||
| "DELETE FROM addresses WHERE cached_transparent_receiver_address = ?", | ||
| [Some(taddr.encode(st.network()))], | ||
| ) | ||
| .unwrap(); | ||
|
|
||
| let res2 = st.wallet_mut().put_received_transparent_utxo(&utxo2); | ||
| assert_matches!(res2, Err(_)); |
There was a problem hiding this comment.
This last part of the test was not migrated across as it requires a new wallet trait method. I decided to drop it instead as I am not convinced this is a useful thing to test.
@nuttycom @str4d are you able to comment if we actually do want to keep this and should require wallets to implement a delete_address method?
There was a problem hiding this comment.
We don't need to keep this, but it should probably be replaced by the equivalent test that we get an error if putting a UTXO with an address that isn't in the wallet (which can be done by crafting such a UTXO in the test).
str4d
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the work of #1543 this moves the remainder of the tests specific to handling transparent transactions out of the
zcash_client_sqlitecrate and allows them to be consumed by different back-end implementations