-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post-release merge of zcash_client_sqlite-0.12.1
back to main
.
#1568
Conversation
In scan progress computation, `recover_until_height` was incorrectly being treated as an inclusive end, meaning that it was possible for a block's notes to be counted both within the recovery range and within the scanning range.
We now compute the fallback tree size at the birthday height and the recover-until height separately in order to avoid the mixing of concerns.
…ecovery_progress` methods.
zcash_client_sqlite: Fix errors in progress computation.
…_sqlite-0.12.1-merge
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1568 +/- ##
==========================================
+ Coverage 61.62% 61.63% +0.01%
==========================================
Files 148 148
Lines 18825 18836 +11
==========================================
+ Hits 11601 11610 +9
- Misses 7224 7226 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 8cce254
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Post-hoc ACK
No description provided.