Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zcash_address 0.6.0, zcash_primitives 0.19.0, zcash_proofs 0.19.0 #1556

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Oct 2, 2024

No description provided.

@str4d str4d requested review from nuttycom and daira October 2, 2024 21:15
daira
daira previously approved these changes Oct 2, 2024
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.63%. Comparing base (ee4692a) to head (091a0bf).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1556   +/-   ##
=======================================
  Coverage   61.63%   61.63%           
=======================================
  Files         148      148           
  Lines       18821    18821           
=======================================
  Hits        11601    11601           
  Misses       7220     7220           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@nuttycom nuttycom merged commit 69cca07 into main Oct 2, 2024
28 checks passed
@nuttycom nuttycom deleted the zcash_primitives-0.19.0-etc branch October 2, 2024 21:50
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-hoc ACK 091a0bf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants