-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to sapling-crypto 0.3
, orchard 0.10
#1554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK with question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1554 +/- ##
==========================================
- Coverage 61.63% 61.63% -0.01%
==========================================
Files 148 148
Lines 18821 18821
==========================================
- Hits 11601 11600 -1
- Misses 7220 7221 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-utACK
@@ -10,7 +10,8 @@ and this library adheres to Rust's notion of | |||
## [0.17.0] - 2024-08-26 | |||
|
|||
### Changed | |||
- Update dependencies to `zcash_protocol 0.3.0`, `zcash_address 0.5.0` | |||
- Update dependencies to `incrementalmerkletree 0.7`, `orchard 0.10`, | |||
`sapling-crypto 0.3`, `zcash_protocol 0.3.0`, `zcash_address 0.5.0`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I edited the wrong part of the changelog here and it wasn't caught in review. I'll fix this in the release train PR.
No description provided.