Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework WalletTest::get_confirmed_sends trait method #1551

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Sep 27, 2024

No description provided.

@str4d str4d force-pushed the 1544-zcb-confirmed-sends-struct branch from 00c3b46 to 63e80ec Compare September 27, 2024 18:24
nuttycom
nuttycom previously approved these changes Sep 27, 2024
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK with request for additional documentation

zcash_client_backend/src/data_api.rs Show resolved Hide resolved
@str4d
Copy link
Contributor Author

str4d commented Sep 27, 2024

Force-pushed to add requested documentation.

Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 9b8094b

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.63%. Comparing base (d8db481) to head (9b8094b).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
zcash_client_backend/src/data_api/testing/pool.rs 87.50% 2 Missing ⚠️
zcash_client_sqlite/src/lib.rs 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1551      +/-   ##
==========================================
+ Coverage   61.32%   61.63%   +0.31%     
==========================================
  Files         147      148       +1     
  Lines       18667    18821     +154     
==========================================
+ Hits        11447    11600     +153     
- Misses       7220     7221       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nuttycom nuttycom merged commit 1410f14 into main Sep 27, 2024
28 checks passed
@nuttycom nuttycom deleted the 1544-zcb-confirmed-sends-struct branch September 27, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants