-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zcash_protocol: Set the public mainnet activation height for NU6 #1548
Conversation
ccd5a78
to
089905a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1548 +/- ##
=======================================
Coverage 61.32% 61.32%
=======================================
Files 147 147
Lines 18667 18667
=======================================
+ Hits 11447 11448 +1
+ Misses 7220 7219 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is blocked on getting the mainnet FPF funding address (which has been requested). I know that this crate doesn't need that address (nor does anything else in librustzcash), but without it the NU6 consensus changes are not well-defined on mainnet.
utACK once that is done.
We have that address now: https://github.com/zcash/zcash/pull/6951/files#diff-ff53e63501a5e89fd650b378c9708274df8ad5d38fcffa6c64be417c4d438b6dR253-R255 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Closes #1356.