Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zcash_protocol: Set the public mainnet activation height for NU6 #1548

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Sep 24, 2024

Closes #1356.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.32%. Comparing base (d8db481) to head (089905a).
Report is 19 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1548   +/-   ##
=======================================
  Coverage   61.32%   61.32%           
=======================================
  Files         147      147           
  Lines       18667    18667           
=======================================
+ Hits        11447    11448    +1     
+ Misses       7220     7219    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is blocked on getting the mainnet FPF funding address (which has been requested). I know that this crate doesn't need that address (nor does anything else in librustzcash), but without it the NU6 consensus changes are not well-defined on mainnet.

utACK once that is done.

@str4d
Copy link
Contributor Author

str4d commented Oct 2, 2024

This is blocked on getting the mainnet FPF funding address

We have that address now: https://github.com/zcash/zcash/pull/6951/files#diff-ff53e63501a5e89fd650b378c9708274df8ad5d38fcffa6c64be417c4d438b6dR253-R255

Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@str4d str4d merged commit 329b5e3 into main Oct 2, 2024
28 checks passed
@str4d str4d deleted the nu6-mainnet-height branch October 2, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

librustzcash consensus support for NU6
3 participants