zcash_client_sqlite: Fix bad WalletTest import that breaks downstream builds.
#1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuttycom
changed the title
WalletTest import that breaks downstre…WalletTest import that breaks downstream builds.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1542 +/- ##
=======================================
Coverage 60.51% 60.51%
=======================================
Files 147 147
Lines 17313 17313
=======================================
Hits 10477 10477
Misses 6836 6836 ☔ View full report in Codecov by Sentry. |
str4d
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
ACK 176c0cb. I think this should not conflict with #1543 as they do happen to be identical on the relevant lines, and this PR was an undeclared dependency of https://github.com/Electric-Coin-Company/zec-sqlite-cli/pull/46 so we need this commit to end up in main.
daira
reviewed
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.