zcash_client_backend: Post-merge cleanups to test framework extraction #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1539 +/- ##
=======================================
Coverage 60.42% 60.42%
=======================================
Files 147 147
Lines 17123 17123
=======================================
Hits 10347 10347
Misses 6776 6776 ☔ View full report in Codecov by Sentry. |
This reduces the feature-flag-related `WalletRead` breakage for crate users, and gives us a place to expose even more internal Data Access API implementation details for general testing purposes.
str4d
force-pushed
the
zcb-test-cleanups
branch
from
91aba18
to
bf73a02
Compare
|
Yes it will; that's partly why this PR is a draft (the other part is that I have not finished it, but in any case my changes will be a much smaller diff). |
str4d
force-pushed
the
zcb-test-cleanups
branch
from
099025d
to
ff7f478
Compare
Addresses review comments from #1530.
str4d
force-pushed
the
zcb-test-cleanups
branch
from
ff7f478
to
63c1de3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1530 (review).