zcash_client_backend: Fix tor::grpc module feature flag
#1532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already depend on `rustls` and `webpki-roots` for `tor::http`, but `tonic` has its own feature flag that needs to be enabled for equivalent support in `tor::grpc`. We didn't need that feature flag enabled for the `proto::service::compact_tx_streamer_client` module because those constructors take a `D: TryInto<tonic::transport::Endpoint>`, which abstracts over TLS and leaves it up to the caller. By constrast, in `tor::grpc` we need to construct the `Endpoint` manually from a `Uri` and then configure TLS ourselves.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1532 +/- ##
=======================================
Coverage 61.26% 61.26%
=======================================
Files 146 146
Lines 16890 16890
=======================================
Hits 10347 10347
Misses 6543 6543 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already depend on
rustlsandwebpki-rootsfortor::http, buttonichas its own feature flag that needs to be enabled for equivalent support intor::grpc. We didn't need that feature flag enabled for theproto::service::compact_tx_streamer_clientmodule because those constructors take aD: TryInto<tonic::transport::Endpoint>, which abstracts over TLS and leaves it up to the caller. By constrast, intor::grpcwe need to construct theEndpointmanually from aUriand then configure TLS ourselves.