Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zcash_primitives: Refactor Transaction to permit omitting protocol-specific bundles #1388

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

zcash_primitives: Extract bundle-specific parts of tx serialization

52bb40d
Select commit
Loading
Failed to load commit list.
Open

zcash_primitives: Refactor Transaction to permit omitting protocol-specific bundles #1388

zcash_primitives: Extract bundle-specific parts of tx serialization
52bb40d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 23, 2024 in 0s

56.49% (+0.10%) compared to 2df4497

View this Pull Request on Codecov

56.49% (+0.10%) compared to 2df4497

Details

Codecov Report

Attention: Patch coverage is 73.33333% with 68 lines in your changes missing coverage. Please review.

Project coverage is 56.49%. Comparing base (2df4497) to head (52bb40d).

Files with missing lines Patch % Lines
zcash_primitives/src/transaction/mod.rs 52.54% 28 Missing ⚠️
zcash_primitives/src/transaction/components/tze.rs 0.00% 18 Missing ⚠️
zcash_primitives/src/transaction/sighash_v4.rs 89.39% 7 Missing ⚠️
zcash_primitives/src/transaction/txid.rs 76.92% 6 Missing ⚠️
zcash_primitives/src/transaction/components.rs 50.00% 4 Missing ⚠️
...sh_primitives/src/transaction/components/sprout.rs 89.47% 2 Missing ⚠️
devtools/src/bin/inspect/transaction.rs 0.00% 1 Missing ⚠️
...h_primitives/src/transaction/components/sapling.rs 96.15% 1 Missing ⚠️
zcash_primitives/src/transaction/sighash_v5.rs 88.88% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1388      +/-   ##
==========================================
+ Coverage   56.39%   56.49%   +0.10%     
==========================================
  Files         148      149       +1     
  Lines       19232    19313      +81     
==========================================
+ Hits        10845    10911      +66     
- Misses       8387     8402      +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

View more details on Codecov