Edition 2018 clean up #113
Conversation
|
There is a typo in one of the commit messages, and it looks like this will fail CI due needing a |
Eirik0
force-pushed
the
edition-2018-clean-up
branch
from
56965a7 to
76795a9
Compare
| @@ -18,7 +18,7 @@ macro_rules! curve_impl { | |||
| } | |||
|
|
|||
| impl ::std::fmt::Display for $affine { | |||
| fn fmt(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result { | |||
| fn fmt(&self, f: &mut ::std::fmt::Formatter<'_>) -> ::std::fmt::Result { | |||
There was a problem hiding this comment.
Note: In pairing I did a find and replace on ::std::fmt::Formatter/::std::fmt::Formatter<'_>. cargo fix --edition-idioms would fail here and try to double add the <'_>.
|
|
||
| #[cfg(feature = "multicore")] | ||
| extern crate crossbeam; | ||
| #[cfg(feature = "multicore")] | ||
| extern crate futures_cpupool; |
There was a problem hiding this comment.
Why does this multicore-conditional extern crate disappear, but not the other two?
There was a problem hiding this comment.
extern crate hex_literal stays as expected because of the #[macro_use].
| @@ -23,11 +21,9 @@ extern crate hex_literal; | |||
| #[cfg(test)] | |||
| extern crate rand; | |||
|
|
|||
| #[cfg(test)] | |||
| extern crate rand_xorshift; | |||
There was a problem hiding this comment.
Why does this test-conditional extern crate disappear, but not the extern crate rand?
There were no changes when running |
This PR runs
cargo fix --editionandcargo fix --edition-idiomson all of the modules which needed it, and includes some warning cleanup along the way. The folderszcash_primitives/benches/...andpairing/benches/...were omitted when running the fix because they depend on unstable features, so it is possible that they no longer work. @ebfull suggested updating the benchmarks to use https://docs.rs/criterion/0.2.11/criterion/ which could be done as part of this PR, but might make more sense to be done as follow up.Closes #97.