Fix off-by-one so pedersen_hash doesn't consume too many generators. #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
reviewed
Aug 19, 2019
| let mut segment_generators = params.pedersen_circuit_generators().iter(); | ||
| let boolean_false = Boolean::constant(false); | ||
|
|
||
| let mut segment_i = 0; | ||
| loop { | ||
| while bits.peek().is_some() { |
There was a problem hiding this comment.
This makes the None case of segment_result unreachable, and I'd like this to be more obvious. We could refactor the inner while loop to address this, but it's also probably fine to just call unreachable!() instead of break.
There was a problem hiding this comment.
Fixed in commit Use expect to remove unreachable break.
|
CI failed due to formatting errors in the latest commit. |
|
|
str4d
approved these changes
Aug 20, 2019
ebfull
approved these changes
Aug 20, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
circuit::pedersen_hash::pedersen_hashalways consumes one too many generators becausesegment_generators.next()is called before checkingbits.next().