Code

equihash: Fix some Rust API issues#1088

Code

Merged

str4d merged 34 commits intozcash:equihash-solver-trompzcash/librustzcash:equihash-solver-trompfrom teor2345:equihash-solver-trompteor2345/librustzcash:equihash-solver-trompCopy head branch name to clipboardJan 26, 2024

+454-158

Commits

Commits on Jan 11, 2024

• Verify compressed solutions in tests

  teor2345

  committed
  8b72e5c

  Copy full SHA for 8b72e5c

• Satisfy some lints

  teor2345

  committed
  5a379ae

  Copy full SHA for 5a379ae

• Only recompile C code if it has changed

  teor2345

  committed
  37bd242

  Copy full SHA for 37bd242

• Use a 2-byte nonce range in the test

  teor2345

  committed
  a73577c

  Copy full SHA for a73577c

• Print solution candidates for debugging

  teor2345

  committed
  f379976

  Copy full SHA for f379976

• Add review comments

  teor2345

  committed
  ca77763

  Copy full SHA for ca77763

• Only do 30 runs for time trials

  teor2345

  committed
  18062e4

  Copy full SHA for 18062e4

• Move allocation out of the loop

  teor2345

  committed
  04251a0

  Copy full SHA for 04251a0

• Add safety comments

  teor2345

  committed
  2ae77d5

  Copy full SHA for 2ae77d5

• Skip already tried nonces

  teor2345

  committed
  c5f0e2e

  Copy full SHA for c5f0e2e

• More safety comments

  teor2345

  committed
  5b06acf

  Copy full SHA for 5b06acf

• Fix a memory handling issue in the solution array

  teor2345

  committed
  e0ff3ec

  Copy full SHA for e0ff3ec

• Avoid a panic by ignoring overflow when shifting

  teor2345

  committed
  41f4035

  Copy full SHA for 41f4035

• Restore the duplicate indexes check

  teor2345

  committed
  d16a40f

  Copy full SHA for d16a40f

• Disable debug-printing in production code

  teor2345

  committed
  d8745c9

  Copy full SHA for d8745c9

• Just print duplicate indexes

  teor2345

  committed
  4da29c8

  Copy full SHA for 4da29c8

• Fix a C++ to C conversion bug with references

  teor2345

  committed
  7e7018e

  Copy full SHA for 7e7018e

• Fix unbraced conditional bugs in unused code

  teor2345

  committed
  5dfd2ad

  Copy full SHA for 5dfd2ad

• Add some redundant cleanup code, but comment it out

  teor2345

  committed
  3053149

  Copy full SHA for 3053149

• Test 4 bytes of changing nonce

  teor2345

  committed
  6d284e2

  Copy full SHA for 6d284e2

• Comment out some verbose debug code

  teor2345

  committed
  b9c5095

  Copy full SHA for b9c5095

• Fix a type cast error in compress_array() C++ to Rust conversion

  teor2345

  committed
  3f60a59

  Copy full SHA for 3f60a59

• Clean up test code

  teor2345

  committed
  0be63ff

  Copy full SHA for 0be63ff

• Add an optional solver feature

  teor2345

  committed
  3043684

  Copy full SHA for 3043684

• Set C pointers to NULL after freeing them to avoid double-frees

  teor2345

  committed
  daaaa6a

  Copy full SHA for daaaa6a

• Fix a memory leak in equi_setstate()

  teor2345

  committed
  5e244ec

  Copy full SHA for 5e244ec

• Check returned solutions are unique

  teor2345

  committed
  d2c4765

  Copy full SHA for d2c4765

• Forward-declare a C function

  teor2345

  committed
  617e3b2

  Copy full SHA for 617e3b2

• Add a portable endian.h for htole32() on macOS and Windows

  teor2345

  committed
  e831375

  Copy full SHA for e831375

• Remove unused thread support to enable Windows compilation

  teor2345

  committed
  cc2f2d7

  Copy full SHA for cc2f2d7

• Don't import a header that's missing in Windows CI

  teor2345

  committed
  742ca1b

  Copy full SHA for 742ca1b

• MSVC demands more constant expressions

  teor2345

  committed
  97a1e0a

  Copy full SHA for 97a1e0a

Commits on Jan 12, 2024

• Clear slots when setting the hash state

  teor2345

  authored
  e879477

  Copy full SHA for e879477

• Keep the C worker up to date with Rust bug fixes

  teor2345

  authored
  aff6fac

  Copy full SHA for aff6fac