Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: use photon geocoder #84

Merged
merged 5 commits into from
Jan 6, 2022
Merged

Search: use photon geocoder #84

merged 5 commits into from
Jan 6, 2022

Conversation

kudlav
Copy link
Contributor

@kudlav kudlav commented Dec 31, 2021

No description provided.

@vercel
Copy link

vercel bot commented Dec 31, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/zbycz/osmapp/GssyghYRfShMrVNahupNJ2jyLMXz
✅ Preview: https://osmapp-git-fork-kudlav-photon-zbycz.vercel.app

@zbycz
Copy link
Owner

zbycz commented Jan 3, 2022

Wow! You are on fire. Thanks so much, this is such a great addition :-)

I have pushed two minor fixes to your branch. Do you think we should merge it already?

@zbycz zbycz changed the title Use photon geocoder Search: use photon geocoder Jan 3, 2022
@kudlav
Copy link
Contributor Author

kudlav commented Jan 3, 2022

Transition after clicking on search option is done.
-> If we know the bbox, then screen fits the bbox. (this is the case of Cities, States, ...)
-> If we don't know the bbox, then center of map is set and the zoom is set to 17. (this is the case of POIs like restaurants)

IMHO it can be merged

@kudlav
Copy link
Contributor Author

kudlav commented Jan 3, 2022

And one more thing to do. Review/update in-app readme or license.

@kudlav
Copy link
Contributor Author

kudlav commented Jan 3, 2022

Seems that no change is required. ✅

This PR wil resolve: #73, #69, #70

@zbycz
Copy link
Owner

zbycz commented Jan 6, 2022

I have found a bug when searching for specific address (Dejvická 6), after the arrow down is pressed, the input is filled with undefined. The option label is constructed with const text = name || buildPhotonAddress(properties); which should be reused in Autocomplete's getOptionLabel prop.

I will try to fix it in the evening.

@zbycz
Copy link
Owner

zbycz commented Jan 6, 2022

Wow, you are fast!
Merging, lets celebrate 🥳

@zbycz zbycz merged commit d40f0e4 into zbycz:master Jan 6, 2022
@kudlav
Copy link
Contributor Author

kudlav commented Jan 7, 2022

Hi, what about villages without street names?

Usually I type the address like Hajany 2, which means place+housenumber. But the results contains only number and the input field is rewritten by 2 when using the arrow keys.

Snímek obrazovky 2022-01-07 v 9 43 32

@zbycz
Copy link
Owner

zbycz commented Jan 10, 2022

It would be great to fix the buildPhotonAddress function for this usecase as well.

@Flohhhhh Flohhhhh mentioned this pull request Jan 19, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants