Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images: Multiple sources for images from center #701

Merged
merged 7 commits into from
Oct 20, 2024

Conversation

Dlurak
Copy link
Collaborator

@Dlurak Dlurak commented Oct 20, 2024

Description

As discussed in #517 this implements kartaview and panoramax.

The kartaview url needs to be special and doesn't go to kartaview.org but to openstreetcam; I should definitely also open a pr at the iD editor as it has this bug.

Example links

Spicy's Gewürzmuseum, Hamburg

Screenshots

image

Copy link

vercel bot commented Oct 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
osmapp ✅ Ready (Inspect) Visit Preview Oct 20, 2024 2:49pm

@Dlurak Dlurak enabled auto-merge (squash) October 20, 2024 14:48
@Dlurak Dlurak merged commit ea2d0fc into zbycz:master Oct 20, 2024
2 checks passed
@kudlav
Copy link
Contributor

kudlav commented Oct 20, 2024

360° images from Panoramax doesn't look right:
https://osmapp.org/node/2087588051
https://osmapp.org/node/451558193

Screenshot_20241020-170437

@Dlurak
Copy link
Collaborator Author

Dlurak commented Oct 20, 2024

I didn't keep panorama images in mind. Thanks for the issue I will fix it right away

Edit:

That's fixed in #702 :)

Copy link

sentry-io bot commented Oct 21, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants