PublicTransport: Select visible routes #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Personally I'm happy with the code but unsure about the design |
|
I am ok with the design. Feel free to merge. As this is only about small part of OsmAPP (the public transport part of FeaturePanel), I am not that opinonated about design. 🙂 If you wanted my suggestion though, I would show just an Eye icon instead of the ThreeDot icon, and toggling it would change the icon to crossed eye icon ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here on #405 @amenk wrote a comment:
@zbycz suggested to only fetch the geometry when the user actively requests it. This isn't implemented in this pr. It only allows toggling the layers.
After each heading there is a small menu with an option to show/hide the category and one option to only show the specific category and hide all others.
Example links
Köln Messe/Deutz (from the screenshots)
Munic Central Station (from the comment)
Screenshots