Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osmApi: Display error on save for 409/412 responses #674

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

kudlav
Copy link
Contributor

@kudlav kudlav commented Oct 13, 2024

Description

When OSM API returns Response 409 or 412, osmapp stops saving without explanation.

Example links

Try to remove this Relation https://osmapp.org/relation/5250576
OSM returns 412 Precondition failed: The relation 5250576 is used in relation 237270.

Same can be with 409 - conflict, see https://wiki.openstreetmap.org/wiki/API_v0.6#Error_codes_15

Screenshots

Error 404, responseText is empty:
image

Error 412:
image
image

Error 410:
image

Checklist

  • dark mode / light mode
  • mobile / desktop
  • server-side-rendering (SSR)

Copy link

vercel bot commented Oct 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
osmapp ✅ Ready (Inspect) Visit Preview Oct 17, 2024 8:21am

@zbycz zbycz changed the title Display error on save for 409/412 responses osmApi: Display error on save for 409/412 responses Oct 17, 2024
@zbycz zbycz merged commit be21412 into zbycz:master Oct 17, 2024
2 checks passed
@zbycz
Copy link
Owner

zbycz commented Oct 17, 2024

👍 👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants