PublicTransport: Add a tooltip to public transport lines #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zbycz
reviewed
Oct 7, 2024
Comment on lines
+29
to
+32
| const formatTags = (tags: Tags) => { | ||
| const parts = [tags.from, ...(tags.via ? [tags.via] : []), tags.to]; | ||
| return parts.flatMap((str) => str.split(';')).join(' - '); | ||
| }; |
There was a problem hiding this comment.
If i understand this correctly, this function is pure, so it can be moved to the top-level. It is always better to use pure functions and also to move them to the top level, because the rest is better readable.
There was a problem hiding this comment.
Yes it is pure. I absolutely love functional programming and try to do things pure whenever I can.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a tooltip showing the route from the
from,viaandtotags.