Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditDialog: add PresetSelect #506

Merged
merged 12 commits into from
Oct 16, 2024
Merged

EditDialog: add PresetSelect #506

merged 12 commits into from
Oct 16, 2024

Conversation

zbycz
Copy link
Owner

@zbycz zbycz commented Sep 3, 2024

Related #222

TODO in a followup:

  • refactor to custom component - get rid of warning MUI: You have provided an out-of-range value amenity/shelter/picnic_shelter for the select component. Consider providing a value that matches one of the available options or ''. The available values are amenity/cafe,...
  • what if more presets are matched?
image image

Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
osmapp ✅ Ready (Inspect) Visit Preview Oct 16, 2024 11:54am

@zbycz zbycz changed the title EditDialog: edesign Edit Dialog to show fields from iD editor EditDialog: redesign Edit Dialog to show fields from iD editor Sep 3, 2024
@zbycz zbycz mentioned this pull request Sep 3, 2024
@zbycz zbycz force-pushed the editdialog-schema branch from 9a8cc79 to 52ae818 Compare October 10, 2024 13:22
@zbycz zbycz changed the title EditDialog: redesign Edit Dialog to show fields from iD editor EditDialog: add FeatureTypeSelect based on id Presets Oct 10, 2024
@zbycz zbycz mentioned this pull request Oct 14, 2024
3 tasks
@zbycz zbycz force-pushed the editdialog-schema branch from 52ae818 to d27bce2 Compare October 15, 2024 16:44
@zbycz zbycz changed the title EditDialog: add FeatureTypeSelect based on id Presets EditDialog: add PresetSelect Oct 15, 2024
@zbycz zbycz force-pushed the editdialog-schema branch from d27bce2 to 9748c7e Compare October 16, 2024 11:45
@zbycz zbycz marked this pull request as ready for review October 16, 2024 11:47
@zbycz zbycz merged commit 402a375 into master Oct 16, 2024
3 checks passed
@zbycz zbycz deleted the editdialog-schema branch October 16, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant