climbing: Change image quality by zooming #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jvaclavik
force-pushed
the
climbing-zoom-change-image-quality
branch
from
5f69537 to
50a7f39
Compare
jvaclavik
force-pushed
the
climbing-zoom-change-image-quality
branch
from
50a7f39 to
7a8eb3e
Compare
jvaclavik
force-pushed
the
climbing-zoom-change-image-quality
branch
from
992deba to
99d7bde
Compare
jvaclavik
force-pushed
the
climbing-zoom-change-image-quality
branch
from
99d7bde to
57a1a9b
Compare
jvaclavik
force-pushed
the
climbing-zoom-change-image-quality
branch
from
57a1a9b to
5c8ff4d
Compare
jvaclavik
force-pushed
the
climbing-zoom-change-image-quality
branch
from
5c8ff4d to
160db52
Compare
jvaclavik
force-pushed
the
climbing-zoom-change-image-quality
branch
from
160db52 to
56e5293
Compare
jvaclavik
force-pushed
the
climbing-zoom-change-image-quality
branch
from
56e5293 to
3ef25af
Compare
jvaclavik
commented
Jul 12, 2024
| @@ -4,7 +4,7 @@ import SplitPane from 'react-split-pane'; | |||
| import ArrowDownwardIcon from '@mui/icons-material/ArrowDownward'; | |||
There was a problem hiding this comment.
This whole file needs some refactoring, will be done in different PR.
jvaclavik
commented
Jul 12, 2024
| @@ -1,5 +1,6 @@ | |||
| export const getContainedSizeImage = (image) => { | |||
| const ratio = image.naturalWidth / image.naturalHeight; | |||
| const ratio = | |||
| image.naturalHeight === 0 ? 0 : image.naturalWidth / image.naturalHeight; | |||
There was a problem hiding this comment.
This was causing really weird visual glitch with width because it was NaN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.