Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI for Windows #176

Merged
merged 11 commits into from
Apr 17, 2024
Merged

Fix CI for Windows #176

merged 11 commits into from
Apr 17, 2024

Conversation

ludovicm67
Copy link
Member

Fixes #173.

Copy link

changeset-bot bot commented Apr 16, 2024

⚠️ No Changeset found

Latest commit: 42d6efa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ludovicm67
Copy link
Member Author

ludovicm67 commented Apr 16, 2024

@tpluscode I started some work here, but no real success for now.
Feel free to try things here if you want :)

@ludovicm67 ludovicm67 marked this pull request as draft April 16, 2024 11:59
@ludovicm67 ludovicm67 marked this pull request as ready for review April 16, 2024 13:10
Copy link
Contributor

@tpluscode tpluscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can avoid duplicate steps with conditionals if you set the node version in the job matrix, like

name: Test validation

on: [push, pull_request]

jobs:
  check-constraint:
-   runs-on: ${{ matrix.os }}
+   runs-on: ${{ matrix.env.os }}
    strategy:
      fail-fast: false
      matrix:
-       os:
-         - ubuntu-latest
-         - windows-latest
+       env:
+        - os: ubuntu-latest
+          node: 20
+        - os: windows-latest
+          node: 20.12.1
    steps:
      - name: Checkout
        uses: actions/checkout@v4

      - name: Set up Node.js
        uses: actions/setup-node@v4
        with:
-         node-version: '20'
+         node-version: ${{ matrix.env.node }}

Copy link
Contributor

@tpluscode tpluscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about updating respec but otherwise LGTM

@ludovicm67 ludovicm67 merged commit e1b27ae into main Apr 17, 2024
25 checks passed
@ludovicm67 ludovicm67 deleted the ci-win-fix branch April 17, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI jobs on Windows are failing
2 participants