-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI for Windows #176
Fix CI for Windows #176
Conversation
|
@tpluscode I started some work here, but no real success for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can avoid duplicate steps with conditionals if you set the node version in the job matrix, like
name: Test validation
on: [push, pull_request]
jobs:
check-constraint:
- runs-on: ${{ matrix.os }}
+ runs-on: ${{ matrix.env.os }}
strategy:
fail-fast: false
matrix:
- os:
- - ubuntu-latest
- - windows-latest
+ env:
+ - os: ubuntu-latest
+ node: 20
+ - os: windows-latest
+ node: 20.12.1
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Set up Node.js
uses: actions/setup-node@v4
with:
- node-version: '20'
+ node-version: ${{ matrix.env.node }}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about updating respec but otherwise LGTM
Fixes #173.