Require that a member object before a 'this' base object must be priv…

…ate, closes hsutter#336
zaucy · Dec 5, 2023 · e2fc400 · e2fc400
1 parent 0c34c2b
commit e2fc400
Showing 1 changed file with 18 additions and 3 deletions.
diff --git a/source/cppfront.cpp b/source/cppfront.cpp
@@ -4928,7 +4928,8 @@ class cppfront
                     decl->get_decl_if_type_scope_object_name_before_a_base_type(*decl->name())
                     || decl->has_name("this")
                     ;
-                if (emit_as_base) {
+                if (emit_as_base)
+                {
                     if (decl->has_name("this")) {
                         if (printer.get_phase() == printer.phase1_type_defs_func_decls) {
                             printer.print_cpp2(
@@ -4938,7 +4939,20 @@ class cppfront
                             separator = ",";
                         }
                     }
-                    else {
+                    else
+                    {
+                        if (
+                            decl->access
+                            && *decl->access != "public"
+                            )
+                        {
+                            errors.emplace_back(
+                                decl->position(),
+                                "a member object that appears before a 'this' base type object must be private (the default)"
+                            );
+                            return;
+                        }
+
                         if (printer.get_phase() == printer.phase1_type_defs_func_decls) {
                             printer.print_cpp2(
                                 separator + " private cpp2::store_as_base<\""
@@ -4952,7 +4966,8 @@ class cppfront
                     }
                 }
                 //  Then we'll switch to start the body == other members
-                else {
+                else
+                {
                     if (printer.get_phase() == printer.phase1_type_defs_func_decls) {
                         if (!started_body) {
                             printer.print_cpp2(" {", compound_stmt->position());