Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support releases with multiple changelogs #39

Merged
merged 17 commits into from
Nov 30, 2020
Merged

Conversation

dobladov
Copy link
Collaborator

@dobladov dobladov commented Nov 4, 2020

Added

  • Support releases with multiple changelogs

@dobladov dobladov added the bug label Nov 4, 2020
@dobladov dobladov self-assigned this Nov 4, 2020
Copy link
Contributor

@gotbahn gotbahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure we are targeting the same, I was thinking about next

  1. Determinate release branch
  2. Check modified project/package folders, can come as input or recursively check which ones containing changelogs
  3. If folder contains changes, then start checking changelog
    3.1. Last changelog entry has version and date
    3.2 Last changelog version matches one in sibling package.json & -lock
    3.3. Target branch changelog version !== last entry one

CHANGELOG.md Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
src/index.js Outdated
* If only one changelog is modified
* there is no doubt of which one is correct
*/
if (changelogs.length === 1) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no guarantee it's true

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we are talking about release branch, in this case at least one must be modified.
And it case is not the correct one it should fail in the rest of the checks.

Copy link

@nitzanashi nitzanashi Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's say I didn't modified the Changelog of SEO but I created a release Branch and PR to production, it might be that other changelogs are modified (e.g. App, embed) so It won't fail because there are changelogs that are being updated but these are not the one that we interested in.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check only happens when only 1 changelog is modified, in this example you are modifying more than one, so it won't go to this check.

But lest's say that we had only 1 previous modified changelog, you could trigger this check only if you did not modify at all the changelog for SEO, but why make a release branch if you don't make any change?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that why we have The changelog action? to validate this?

src/release.js Outdated Show resolved Hide resolved
src/release.js Outdated Show resolved Hide resolved
src/release.js Outdated Show resolved Hide resolved
src/release.js Outdated Show resolved Hide resolved
src/release.js Outdated Show resolved Hide resolved
src/release.js Outdated Show resolved Hide resolved
Co-authored-by: Bogdan Plieshka <[email protected]>
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@dobladov dobladov marked this pull request as ready for review November 25, 2020 15:41
@dobladov dobladov requested a review from gotbahn November 25, 2020 15:41
src/files.js Outdated Show resolved Hide resolved
@dobladov
Copy link
Collaborator Author

@z-merge it

@dobladov dobladov merged commit 8a1438c into master Nov 30, 2020
@dobladov dobladov deleted the Multi-release-support branch November 30, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants