-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support releases with multiple changelogs #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be sure we are targeting the same, I was thinking about next
- Determinate release branch
- Check modified project/package folders, can come as input or recursively check which ones containing changelogs
- If folder contains changes, then start checking changelog
3.1. Last changelog entry has version and date
3.2 Last changelog version matches one in sibling package.json & -lock
3.3. Target branch changelog version !== last entry one
src/index.js
Outdated
* If only one changelog is modified | ||
* there is no doubt of which one is correct | ||
*/ | ||
if (changelogs.length === 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no guarantee it's true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we are talking about release branch, in this case at least one must be modified.
And it case is not the correct one it should fail in the rest of the checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's say I didn't modified the Changelog of SEO but I created a release Branch and PR to production, it might be that other changelogs are modified (e.g. App, embed) so It won't fail because there are changelogs that are being updated but these are not the one that we interested in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check only happens when only 1 changelog is modified, in this example you are modifying more than one, so it won't go to this check.
But lest's say that we had only 1 previous modified changelog, you could trigger this check only if you did not modify at all the changelog for SEO, but why make a release branch if you don't make any change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't that why we have The changelog action? to validate this?
Co-authored-by: Bogdan Plieshka <[email protected]>
Co-authored-by: Bogdan Plieshka <[email protected]>
Co-authored-by: Bogdan Plieshka <[email protected]>
…ngelog into Multi-release-support
@z-merge it |
Added