-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker build #14
Add docker build #14
Conversation
I found my issue. The sub- |
environment.yml
Outdated
channels: | ||
- defaults | ||
- ome | ||
- conda-forge | ||
- anaconda |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anaconda
is a weird metachannel, which isn't really intended for public use. conda-forge
should be higher priority than defaults
as that is how conda-forge
packages are built and intended to be used.
channels: | |
- defaults | |
- ome | |
- conda-forge | |
- anaconda | |
channels: | |
- ome | |
- conda-forge | |
- defaults |
environment.yml
Outdated
- pip: | ||
- pre-commit | ||
- pytest-qt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conda-forge
packages of both of these exist. That said, do we need pre-commit
? Is this environment intended for development or just testing?
- pip: | |
- pre-commit | |
- pytest-qt | |
- pre-commit | |
- pytest-qt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. This is a copy of the ome-zarr-py dev environment. Thanks for catching it.
Thanks @joshmoore. I think the failures you see are because I haven't merged #7 yet. |
Updated based on @jakirkham's feedback and added a github workflow. |
I keep forgetting this...
Doh. I hadn't seen #12 -- Happy to rollback those changes, but https://github.com/constantinpape/zarr_implementations/actions/runs/361203107 now represents what I'm seeing locally. |
@joshmoore this looks good. I am merging and deprecating #12. |
I recently ran into an issue opening n5 from zarr. I figured this repo was a good place to start to figure out what's going on. I'll see if I can make a change that makes that test fail. In the meantime, this is the setup I used to build locally. Note that there are a few failures: